Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(465)

Issue 7413049: code review 7413049: runtime: add garbage collector statistics (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by atom
Modified:
12 years ago
Reviewers:
CC:
golang-dev, dvyukov, rsc
Visibility:
Public.

Description

runtime: add garbage collector statistics If the constant CollectStats is non-zero and GOGCTRACE=1 the garbage collector will print basic statistics about executed GC instructions.

Patch Set 1 #

Patch Set 2 : diff -r 2e9e27f95e17 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 2e9e27f95e17 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 8a08842f7978 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -1 line) Patch
M src/pkg/runtime/mgc0.c View 1 2 12 chunks +77 lines, -1 line 0 comments Download

Messages

Total messages: 8
atom
Hello golang-dev@googlegroups.com (cc: rsc), I'd like you to review this change to https://go.googlecode.com/hg/
12 years ago (2013-03-03 08:41:42 UTC) #1
dvyukov
On Sun, Mar 3, 2013 at 10:41 AM, <0xE2.0x9A.0x9B@gmail.com> wrote: > Reviewers: golang-dev1, > > ...
12 years ago (2013-03-03 08:56:20 UTC) #2
atom
On 2013/03/03 08:56:20, dvyukov wrote: > On Sun, Mar 3, 2013 at 10:41 AM, <mailto:0xE2.0x9A.0x9B@gmail.com> ...
12 years ago (2013-03-03 09:01:29 UTC) #3
dvyukov
On 2013/03/03 09:01:29, atom wrote: > On 2013/03/03 08:56:20, dvyukov wrote: > > On Sun, ...
12 years ago (2013-03-03 09:04:05 UTC) #4
atom
Hello golang-dev@googlegroups.com, dvyukov@google.com (cc: golang-dev@googlegroups.com, rsc@golang.org), Please take another look.
12 years ago (2013-03-03 09:48:08 UTC) #5
dvyukov
LGTM
12 years ago (2013-03-03 15:32:37 UTC) #6
rsc
LGTM
12 years ago (2013-03-04 15:22:50 UTC) #7
atom
12 years ago (2013-03-04 15:54:45 UTC) #8
*** Submitted as https://code.google.com/p/go/source/detail?r=a565c143b41b ***

runtime: add garbage collector statistics

If the constant CollectStats is non-zero and GOGCTRACE=1
the garbage collector will print basic statistics about executed
GC instructions.

R=golang-dev, dvyukov
CC=golang-dev, rsc
https://codereview.appspot.com/7413049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b