code review 7411047: syscall: Plan 9: keep a consistent environment array

syscall: Plan 9: keep a consistent environment array

Map order is non-deterministic. Introduce a new
environment string array that tracks the env map.
This allows us to produce identical results for
Environ() upon successive calls, as expected by the
TestConsistentEnviron test in package os.

[akumar, 2013-02-27 19:46:42]

Hello rsc@golang.org, ality@pbrane.org, rminnich@gmail.com, bradfitz@golang.org
(cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[r, 2013-02-27 19:49:47]

https://codereview.appspot.com/7411047/diff/4001/src/pkg/syscall/env_plan9.go
File src/pkg/syscall/env_plan9.go (right):

https://codereview.appspot.com/7411047/diff/4001/src/pkg/syscall/env_plan9.go...
src/pkg/syscall/env_plan9.go:143: return a
this is fine but you could eliminate two lines of code with

return append([]string(nil), envs...)

[akumar, 2013-02-28 01:54:57]

PTAL.

https://codereview.appspot.com/7411047/diff/4001/src/pkg/syscall/env_plan9.go
File src/pkg/syscall/env_plan9.go (right):

https://codereview.appspot.com/7411047/diff/4001/src/pkg/syscall/env_plan9.go...
src/pkg/syscall/env_plan9.go:143: return a
On 2013/02/27 19:49:47, r wrote:
> this is fine but you could eliminate two lines of code with
> 
> return append([]string(nil), envs...)

Done.

[r, 2013-02-28 02:41:21]

LGTM

[rminnich, 2013-02-28 05:39:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=c08c995f8058 ***

syscall: Plan 9: keep a consistent environment array

Map order is non-deterministic. Introduce a new
environment string array that tracks the env map.
This allows us to produce identical results for
Environ() upon successive calls, as expected by the
TestConsistentEnviron test in package os.

R=rsc, ality, rminnich, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/7411047

Committer: Ron Minnich <rminnich@gmail.com>