store: sum counter prefixes without perfect match

store: sum counter prefixes without perfect match

This means a:b:* won't include the count for a:b itself. This is
the most desired outcome in practice, and matches with the output
of listing a:b:* (the aggregated sum without ?list=1 now matches
the sum of all counts in a listing with ?list=1).

https://code.launchpad.net/~niemeyer/juju-core/store-counter-sum-tunning/+merge/150934

(do not edit description out of merge proposal)

[niemeyer, 2013-02-27 22:47:17]

Please take a look.

[dave_cheney.net, 2013-02-27 23:06:14]

LGTM. I'll leave you and thumper to argue about the boolean flag; it was there
before this change.

https://codereview.appspot.com/7407052/diff/1/store/server_test.go
File store/server_test.go (right):

https://codereview.appspot.com/7407052/diff/1/store/server_test.go#newcode177
store/server_test.go:177: "a":     "1",
What about "a:b:c" ?

[niemeyer, 2013-02-27 23:09:20]

Thanks for the review.

https://codereview.appspot.com/7407052/diff/1/store/server_test.go
File store/server_test.go (right):

https://codereview.appspot.com/7407052/diff/1/store/server_test.go#newcode177
store/server_test.go:177: "a":     "1",
On 2013/02/27 23:06:14, dfc wrote:
> What about "a:b:c" ?

Good idea. I'll add it.

[niemeyer, 2013-02-27 23:16:08]

*** Submitted:

store: sum counter prefixes without perfect match

This means a:b:* won't include the count for a:b itself. This is
the most desired outcome in practice, and matches with the output
of listing a:b:* (the aggregated sum without ?list=1 now matches
the sum of all counts in a listing with ?list=1).

R=dfc
CC=
https://codereview.appspot.com/7407052