Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(346)

Issue 7407045: code review 7407045: cmd/vet: eliminate false positives for slices in untagg... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by r
Modified:
12 years, 3 months ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

cmd/vet: eliminate false positives for slices in untagged literal test Made possible by go/types, as long as the package type-checks OK. Fixes issue 4684.

Patch Set 1 #

Patch Set 2 : diff -r 886c91b4ae3c https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M src/cmd/vet/Makefile View 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/vet/taglit.go View 3 chunks +35 lines, -3 lines 0 comments Download

Messages

Total messages: 4
r
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 3 months ago (2013-02-23 23:57:43 UTC) #1
r
*** Submitted as https://code.google.com/p/go/source/detail?r=17d4a0010fd8 *** cmd/vet: eliminate false positives for slices in untagged literal test ...
12 years, 3 months ago (2013-02-24 21:18:28 UTC) #2
r
Submitted in error; will handle any comments separately. -rob
12 years, 3 months ago (2013-02-24 21:19:12 UTC) #3
rsc
12 years, 3 months ago (2013-02-25 22:04:30 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b