Issue 7402054: code review 7402054: cmd/gc: can stop tracking gotype in regopt

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7402054: code review 7402054: cmd/gc: can stop tracking gotype in regopt (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by rsc

Modified:
12 years, 3 months ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/gc: can stop tracking gotype in regopt Now that the type information is in TYPE instructions that are not rewritten by the optimization passes, we don't have to try to preserve the type information (no longer) attached to MOV instructions.

Patch Set 1 #

Patch Set 2 : diff -r 1c50db40d078 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1c50db40d078 https://go.googlecode.com/hg/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
M	src/cmd/5g/reg.c	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/cmd/6g/reg.c	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/cmd/8g/reg.c	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/cmd/gc/go.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 3 months ago (2013-02-25 21:11:32 UTC) #1

rsc

12 years, 3 months ago (2013-02-25 21:11:40 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=20c2dc87cf40 ***

cmd/gc: can stop tracking gotype in regopt

Now that the type information is in TYPE instructions
that are not rewritten by the optimization passes,
we don't have to try to preserve the type information
(no longer) attached to MOV instructions.

R=ken2
CC=golang-dev
https://codereview.appspot.com/7402054

Expand All Messages | Collapse All Messages