Issue 7402047: code review 7402047: runtime: implement local work queues (in preparation fo...

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+243 lines, -0 lines)			Patch
M	src/pkg/runtime/export_test.go	View	1 3	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/proc.c	View	1 2 3 4 5 6	2 chunks	+217 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/proc_test.go	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2 3 4	2 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 3 months ago (2013-02-21 13:54:21 UTC) #1

rsc

LGTM https://codereview.appspot.com/7402047/diff/12001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/7402047/diff/12001/src/pkg/runtime/proc.c#newcode1798 src/pkg/runtime/proc.c:1798: q = (G**)runtime·malloc(2*s*sizeof(*q)); remove (G**) cast. thankfully, this ...

12 years, 3 months ago (2013-02-22 22:41:18 UTC) #2

dvyukov

*** Submitted as https://code.google.com/p/go/source/detail?r=16ab8cd39afe *** runtime: implement local work queues (in preparation for new scheduler) ...

12 years, 3 months ago (2013-02-23 04:49:26 UTC) #3

dvyukov

12 years, 3 months ago (2013-02-23 04:49:32 UTC) #4

Message was sent while issue was closed.

On 2013/02/22 22:41:18, rsc wrote:
> LGTM
> 
> https://codereview.appspot.com/7402047/diff/12001/src/pkg/runtime/proc.c
> File src/pkg/runtime/proc.c (right):
> 
>
https://codereview.appspot.com/7402047/diff/12001/src/pkg/runtime/proc.c#newc...
> src/pkg/runtime/proc.c:1798: q = (G**)runtime·malloc(2*s*sizeof(*q));
> remove (G**) cast. thankfully, this isn't c++.
> 
>
https://codereview.appspot.com/7402047/diff/12001/src/pkg/runtime/proc.c#newc...
> src/pkg/runtime/proc.c:1882: p.runq =
> (G**)runtime·malloc(p.runqsize*sizeof(*p.runq));
> remove cast.
> 
>
https://codereview.appspot.com/7402047/diff/12001/src/pkg/runtime/proc.c#newc...
> src/pkg/runtime/proc.c:1911: p1.runq =
> (G**)runtime·malloc(p1.runqsize*sizeof(*p1.runq));
> remove cast.
> 
>
https://codereview.appspot.com/7402047/diff/12001/src/pkg/runtime/proc.c#newc...
> src/pkg/runtime/proc.c:1917: p2.runq =
> (G**)runtime·malloc(p2.runqsize*sizeof(*p2.runq));
> remove cast.

Done

Expand All Messages | Collapse All Messages