Issue 7401053: code review 7401053: libmach: fix build (set and not used)

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7401053: code review 7401053: libmach: fix build (set and not used) (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:
bradfitz

CC:
golang-dev

Visibility:
Public.

Description

libmach: fix build (set and not used)

Patch Set 1 #

Patch Set 2 : diff -r 0add1de89fe4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 0add1de89fe4 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/libmach/sym.c	View	1	2 chunks	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-02-27 03:51:45 UTC) #1

rsc

*** Submitted as https://code.google.com/p/go/source/detail?r=bf0518a9f420 *** libmach: fix build (set and not used) TBR=golang-dev CC=golang-dev https://codereview.appspot.com/7401053

12 years ago (2013-02-27 03:51:53 UTC) #2

bradfitz

12 years ago (2013-02-27 03:56:32 UTC) #3

LGTM

On Tue, Feb 26, 2013 at 7:51 PM, <rsc@golang.org> wrote:

> Reviewers: golang-dev_googlegroups.com,
>
> Message:
> Hello golang-dev (cc: golang-dev@googlegroups.com),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> libmach: fix build (set and not used)
>
> Please review this at
https://codereview.appspot.**com/7401053/<https://codereview.appspot.com/7401...
>
> Affected files:
>   M src/libmach/sym.c
>
>
> Index: src/libmach/sym.c
> ==============================**==============================**=======
> --- a/src/libmach/sym.c
> +++ b/src/libmach/sym.c
> @@ -110,7 +110,7 @@
>  {
>         Sym *p;
>         int32 i, l, size;
> -       vlong vl, off;
> +       vlong vl;
>         Biobuf b;
>         int svalsz, newformat, shift;
>         uvlong (*swav)(uvlong);
> @@ -167,7 +167,6 @@
>         size = 0;
>         for(p = symbols; size < fp->symsz; p++, nsym++) {
>                 if(newformat) {
> -                       off = Boffset(&b);
>                         // Go 1.1 format. See comment at top of
> ../pkg/runtime/symtab.c.
>                         if(Bread(&b, &c, 1) != 1)
>                                 return symerrmsg(1, "symbol");
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

Expand All Messages | Collapse All Messages