Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(52)

Issue 7400057: Make test-output-distance regtest contain span bars (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by dak
Modified:
11 years ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make test-output-distance regtest contain span bars Since span bars don't turn up in the metrics, the regtests don't show them. To make catastrophic span bar failures show up at least somewhere, the ever-changing test-output-distance test is made to include them.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M input/regression/test-output-distance.ly View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 5
lemzwerg
LGTM.
11 years, 2 months ago (2013-02-27 19:15:27 UTC) #1
thomasmorley65
LGTM One suggestion: https://codereview.appspot.com/7400057/diff/1/input/regression/test-output-distance.ly File input/regression/test-output-distance.ly (right): https://codereview.appspot.com/7400057/diff/1/input/regression/test-output-distance.ly#newcode20 input/regression/test-output-distance.ly:20: How about setting \bar "|." Might ...
11 years, 2 months ago (2013-02-28 00:45:57 UTC) #2
dak
On 2013/02/28 00:45:57, thomasmorley65 wrote: > LGTM > > One suggestion: > > https://codereview.appspot.com/7400057/diff/1/input/regression/test-output-distance.ly > ...
11 years, 2 months ago (2013-02-28 05:57:45 UTC) #3
Keith
LGTM. On 2013/02/28 05:57:45, dak wrote: > I think we have a special span bar ...
11 years, 2 months ago (2013-03-02 07:30:11 UTC) #4
dak
11 years, 1 month ago (2013-03-05 14:58:45 UTC) #5
On 2013/03/02 07:30:11, Keith wrote:
> LGTM.
> 
> On 2013/02/28 05:57:45, dak wrote:
>  
> > I think we have a special span bar at the start,
> The bar at the start is a SystemStartBar, which was not affected by the recent
> span-bar bug.  You might want an extra measure, and a final bar, then.  Also,
> some note in the texidoc saying that this test should have span bars.

I think that this issue can be made to explode into arbitrary overkill.  I'd
rather just commit it as-is and leave further improvements to whoever considers
them really pressing.  There is at least one span bar now, and a multimeasure
rest (I seem to remember that those were somewhat weak in metrics as well, but
whether or not this is the case, this is about the most simple content for
another staff anyway).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b