Issue 7399054: state/statecmd: add ServiceSetYAML

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7399054: state/statecmd: add ServiceSetYAML

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by rog

Modified:
11 years, 2 months ago

Reviewers:
mp+150575, dimitern, TheMue

Visibility:
Public.

Description

state/statecmd: add ServiceSetYAML Also sort out the tests somewhat. https://code.launchpad.net/~rogpeppe/juju-core/231-statecmd-ServiceSetYAML/+merge/150575 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/statecmd: add ServiceSetYAML #

Total comments: 1

Patch Set 3 : state/statecmd: add ServiceSetYAML #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+128 lines, -57 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	cmd/juju/set.go	View	1 2	1 chunk	+12 lines, -5 lines	0 comments	Download
M	state/statecmd/config.go	View		2 chunks	+25 lines, -11 lines	0 comments	Download
M	state/statecmd/config_test.go	View		3 chunks	+89 lines, -41 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM, although some kind of validation/type checking should be done.

11 years, 2 months ago (2013-02-26 15:07:34 UTC) #2

rog

On 26 February 2013 15:07, <dimiter.naydenov@canonical.com> wrote: > LGTM, although some kind of validation/type checking ...

11 years, 2 months ago (2013-02-26 15:54:53 UTC) #3

TheMue

LGTM, only one small comment. https://codereview.appspot.com/7399054/diff/1001/state/statecmd/config.go File state/statecmd/config.go (right): https://codereview.appspot.com/7399054/diff/1001/state/statecmd/config.go#newcode39 state/statecmd/config.go:39: // TODO(rog) should this ...

11 years, 2 months ago (2013-02-26 15:57:10 UTC) #4

rog

11 years, 2 months ago (2013-02-26 18:32:32 UTC) #5

*** Submitted:

state/statecmd: add ServiceSetYAML

Also sort out the tests somewhat.

R=dimitern, TheMue
CC=
https://codereview.appspot.com/7399054

Expand All Messages | Collapse All Messages