Issue 7398057: Handle browser warning dialog in deploy tests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7398057: Handle browser warning dialog in deploy tests.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by frankban

Modified:
11 years, 2 months ago

Reviewers:
teknico, gary.poster, mp+150869

Visibility:
Public.

Description

Handle browser warning dialog in deploy tests. This branch fixes the test failures caused by Firefox not being able to handle the "your browser is not supported" dialog. Also updated the charm testing branch, including the latest stable release (v0.2.1): see http://bazaar.launchpad.net/~juju-gui/juju-gui/charm-tests-branch/files https://code.launchpad.net/~frankban/charms/precise/juju-gui/bug-1134152-browser-warning/+merge/150869 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Handle browser warning dialog in deploy tests. #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+56 lines, -14 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	revision	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/deploy.test	View	9 chunks	+53 lines, -13 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

gary.poster

LGTM. Thank you! Gary https://codereview.appspot.com/7398057/diff/1/tests/deploy.test File tests/deploy.test (right): https://codereview.appspot.com/7398057/diff/1/tests/deploy.test#newcode88 tests/deploy.test:88: def wait_for(self, condition, error=None, timeout=10): ...

11 years, 2 months ago (2013-02-27 18:26:52 UTC) #2

frankban

On 2013/02/27 18:26:52, gary.poster wrote: > These look familiar. ;-) > I don't have a ...

11 years, 2 months ago (2013-02-28 09:25:59 UTC) #3

teknico

LGTM. Tests passed (with a bit of effort, thanks for the help).

11 years, 2 months ago (2013-02-28 10:20:55 UTC) #4

frankban

On 2013/02/28 10:20:55, teknico wrote: > LGTM. > > Tests passed (with a bit of ...

11 years, 2 months ago (2013-02-28 10:28:29 UTC) #5

frankban

11 years, 2 months ago (2013-02-28 10:29:39 UTC) #6

*** Submitted:

Handle browser warning dialog in deploy tests.

This branch fixes the test failures caused by 
Firefox not being able to handle the 
"your browser is not supported" dialog.

Also updated the charm testing branch, including
the latest stable release (v0.2.1): see
http://bazaar.launchpad.net/~juju-gui/juju-gui/charm-tests-branch/files

R=gary.poster, teknico
CC=
https://codereview.appspot.com/7398057

Expand All Messages | Collapse All Messages