code review 7398055: codereview: don't warn about secret commits

codereview: don't warn about secret commits

Normally the codereview plugin disables adding new commits
when not using the submit command. Unfortunately this makes
it impossible to use the Mercurial Queues extension at the
same time.

A feature called "Phases" was introduced in Mercurial 2.1
that allows marking commits as being secret; this means
they will never be pushed to the upstream repository.

We can take advantage of this feature to allow the use of
Mercurial Queues if the mq.secret option has been set in
hgrc(5) and a recent version of Mercurial is used.

[ality, 2013-02-27 09:32:10]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2013-02-27 16:40:32]

LGTM

[ality, 2013-02-28 14:49:44]

PTAL

This version should be correct. I forgot that
phases were not present in versions before 2.1.

Also, it seems that the phase is set after the
pretxncommit hook, oddly enough, so I changed
it to use the same logic as the mq extension.

[ality, 2013-03-07 16:47:39]

Ping.

[minux1, 2013-03-07 17:24:01]

LGTM.

[rsc, 2013-03-11 15:36:48]

Seems fine but I am confused about how you can use Mercurial Queues at all. 'hg
qfinish' wants to commit a change to the repo, which we can't allow. How do you
actually do anything useful?

[bradfitz, 2013-06-04 22:03:06]

*** Submitted as https://code.google.com/p/go/source/detail?r=f414cea0edce ***

codereview: don't warn about secret commits

Normally the codereview plugin disables adding new commits
when not using the submit command. Unfortunately this makes
it impossible to use the Mercurial Queues extension at the
same time.

A feature called "Phases" was introduced in Mercurial 2.1
that allows marking commits as being secret; this means
they will never be pushed to the upstream repository.

We can take advantage of this feature to allow the use of
Mercurial Queues if the mq.secret option has been set in
hgrc(5) and a recent version of Mercurial is used.

R=golang-dev, rsc, minux.ma
CC=golang-dev
https://codereview.appspot.com/7398055

Committer: Brad Fitzpatrick <bradfitz@golang.org>