Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(751)

Issue 7398052: Revert r1829: Fix failure to recover from GPU hang. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by apatrick1
Modified:
11 years, 2 months ago
Reviewers:
kbr1, nicolas
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Revert r1829: Fix failure to recover from GPU hang. It's causing trouble with Aura. Locking the screen seems to generate the display mode change device status and Aura cannot recover. http://crbug.com/178148 Committed: https://code.google.com/p/angleproject/source/detail?r=1834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M src/libEGL/Display.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 4
apatrick1
Locking the screen generates S_PRESENT_MODE_CHANGED and Aura isn't robust to device lost.
11 years, 2 months ago (2013-02-25 23:39:31 UTC) #1
kbr1
Unfortunate, but LGTM if this is needed for an emergency.
11 years, 2 months ago (2013-02-25 23:40:55 UTC) #2
nicolas
We currently report S_PRESENT_MODE_CHANGED as a lost context in our local dx11proto branch as well ...
11 years, 2 months ago (2013-02-26 16:17:18 UTC) #3
apatrick1
11 years, 2 months ago (2013-02-26 19:02:34 UTC) #4
Message was sent while issue was closed.
On 2013/02/26 16:17:18, nicolas wrote:
> We currently report S_PRESENT_MODE_CHANGED as a lost context in our local
> dx11proto branch as well (which will be merged into the public repository
soon).
> Should we revert it there too or can we expect Aura to be reset robust by the
> time this branch is merged into the master branch?

Aura should certainly be robust enough to recover from device lost. I don't
think that should be a consideration for ANGLE.

I have to do some more investigation but I think this is the real issue.
Sometimes a GPU hang is reported with S_PRESENT_MODE_CHANGED rather than an
error. But S_PRESENT_MODE_CHANGED doesn't always mean a GPU hang. It is also
reported when the screen is locked. Losing the context is too harsh a thing to
do just because the screen was locked.

I need a way to differentiate between a GPU hang and the screen being locked and
other things that report S_PRESENT_MODE_CHANGED that do not require the device
be reset. Maybe checking whether GetRenderTargetData succeeds would work.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b