rpc: allow served object to know about shutdown.

rpc: allow served object to know about shutdown.

We want this so that we can clean up watchers
easily when the client goes away.

https://code.launchpad.net/~rogpeppe/juju-core/228-rpc-killer/+merge/150385

(do not edit description out of merge proposal)

[rog, 2013-02-25 17:45:59]

Please take a look.

[dimitern, 2013-02-26 09:00:17]

LGTM

https://codereview.appspot.com/7398050/diff/2001/rpc/rpc_test.go
File rpc/rpc_test.go (right):

https://codereview.appspot.com/7398050/diff/2001/rpc/rpc_test.go#newcode440
rpc/rpc_test.go:440: type TKillerRoot struct {
That reminds me of Borland Delphi - TObject, TWindow :)

https://codereview.appspot.com/7398050/diff/2001/rpc/server.go
File rpc/server.go (right):

https://codereview.appspot.com/7398050/diff/2001/rpc/server.go#newcode75
rpc/server.go:75: type Killer interface {
The best interface so far!

[rog, 2013-02-26 11:22:04]

Please take a look.

[TheMue, 2013-02-26 12:01:56]

LGTM, only one small wish.

https://codereview.appspot.com/7398050/diff/8001/rpc/rpc_test.go
File rpc/rpc_test.go (right):

https://codereview.appspot.com/7398050/diff/8001/rpc/rpc_test.go#newcode440
rpc/rpc_test.go:440: type TKillerRoot struct {
Stuck a bit with the one char prefix. Could be TestRoot and TestKillerRoot.

https://codereview.appspot.com/7398050/diff/8001/rpc/server.go
File rpc/server.go (right):

https://codereview.appspot.com/7398050/diff/8001/rpc/server.go#newcode75
rpc/server.go:75: type Killer interface {
Hehe, funny name.

[dave_cheney.net, 2013-02-27 05:24:14]

LGTM. Thanks.

https://codereview.appspot.com/7398050/diff/8001/rpc/rpc_test.go
File rpc/rpc_test.go (right):

https://codereview.appspot.com/7398050/diff/8001/rpc/rpc_test.go#newcode440
rpc/rpc_test.go:440: type TKillerRoot struct {
On 2013/02/26 12:01:56, TheMue wrote:
> Stuck a bit with the one char prefix. Could be TestRoot and TestKillerRoot.

Yes, please lets not have IFooable, and TChecked

https://codereview.appspot.com/7398050/diff/8001/rpc/server.go
File rpc/server.go (right):

https://codereview.appspot.com/7398050/diff/8001/rpc/server.go#newcode75
rpc/server.go:75: type Killer interface {
On 2013/02/26 12:01:56, TheMue wrote:
> Hehe, funny name.

Sometimes the language hand you these gems.

[rog, 2013-02-27 10:39:01]

*** Submitted:

rpc: allow served object to know about shutdown.

We want this so that we can clean up watchers
easily when the client goes away.

R=dimitern, TheMue, dfc
CC=
https://codereview.appspot.com/7398050

https://codereview.appspot.com/7398050/diff/8001/rpc/rpc_test.go
File rpc/rpc_test.go (right):

https://codereview.appspot.com/7398050/diff/8001/rpc/rpc_test.go#newcode440
rpc/rpc_test.go:440: type TKillerRoot struct {
On 2013/02/26 12:01:56, TheMue wrote:
> Stuck a bit with the one char prefix. Could be TestRoot and TestKillerRoot.

perhaps, but we've already got lots of Test prefixes floating around. any other
suggestions?

in fact, i think i'll just lose the T prefix entirely. i think that'll work ok.