Issue 7398044: Implement environment info API call.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7398044: Implement environment info API call.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by frankban

Modified:
11 years, 2 months ago

Reviewers:
dimitern, mp+149886, fwereade

Visibility:
Public.

Description

Implement environment info API call. The Juju GUI needs an API call to retrieve some details about the Juju environment: provider type and default series. This branch includes this functionality. https://code.launchpad.net/~frankban/juju-core/environment-info/+merge/149886 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 2

Patch Set 2 : Implement environment info API call. #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -0 lines)			Patch
A	[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	state/api/api_test.go	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	state/api/apiclient.go	View		1 chunk	+16 lines, -0 lines	0 comments	Download
M	state/api/apiserver.go	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dimitern

LGTM with a minor suggestion. https://codereview.appspot.com/7398044/diff/1/state/api/apiserver.go File state/api/apiserver.go (right): https://codereview.appspot.com/7398044/diff/1/state/api/apiserver.go#newcode184 state/api/apiserver.go:184: // EnvironmentInfo retrieves details ...

11 years, 2 months ago (2013-02-21 17:58:04 UTC) #2

frankban

*** Submitted: Implement environment info API call. The Juju GUI needs an API call to ...

11 years, 2 months ago (2013-02-22 09:35:34 UTC) #4

frankban

11 years, 2 months ago (2013-02-22 09:38:04 UTC) #5

Hi Dimiter and William,

thanks for the reviews.

https://codereview.appspot.com/7398044/diff/1/state/api/apiserver.go
File state/api/apiserver.go (right):

https://codereview.appspot.com/7398044/diff/1/state/api/apiserver.go#newcode184
state/api/apiserver.go:184: // EnvironmentInfo retrieves details (default series
and type) on the current
On 2013/02/21 17:58:04, dimitern wrote:
> // EnvironmentInfo returns information about the current environment (default
> series and type). ?

Done.

Expand All Messages | Collapse All Messages