Issue 7398043: code review 7398043: syscall: Solaris fixes for passing file descriptor.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7398043: code review 7398043: syscall: Solaris fixes for passing file descriptor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by iant

Modified:
13 years, 3 months ago

Reviewers:

CC:
iant, gofrontend-dev_googlegroups.com

Visibility:
Public.

Description

syscall: Solaris fixes for passing file descriptor. From Rainer Orth. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56171

Patch Set 1 #

Patch Set 2 : diff -r 3b1c3cceaf02 https://gofrontend.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -29 lines)			Patch
M	libgo/Makefile.am	View		3 chunks	+17 lines, -2 lines	0 comments	Download
M	libgo/Makefile.in	View		3 chunks	+14 lines, -2 lines	0 comments	Download
M	libgo/go/syscall/sockcmsg_unix.go	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	libgo/go/syscall/socket.go	View		8 chunks	+0 lines, -24 lines	0 comments	Download
A	libgo/go/syscall/socket_posix.go	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
A	libgo/go/syscall/socket_xnet.go	View	1	1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

iant

Hello iant@golang.org (cc: gofrontend-dev@googlegroups.com), I'd like you to review this change to https://gofrontend.googlecode.com/hg/

13 years, 3 months ago (2013-02-20 20:03:19 UTC) #1

iant

13 years, 3 months ago (2013-02-20 20:03:25 UTC) #2

*** Submitted as
https://code.google.com/p/gofrontend/source/detail?r=7a758385dda3 ***

syscall: Solaris fixes for passing file descriptor.

From Rainer Orth.

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56171

R=iant
CC=gofrontend-dev
https://codereview.appspot.com/7398043

Expand All Messages | Collapse All Messages