Issue 7397061: code review 7397061: runtime: more changes in preparation to the new scheduler

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7397061: code review 7397061: runtime: more changes in preparation to the new scheduler (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by dvyukov

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: more changes in preparation to the new scheduler add per-P cache of dead G's add global runnable queue (not used for now) add list of idle P's (not used for now)

Patch Set 2 : diff -r 02ee8f7b9a17 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 02ee8f7b9a17 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 02ee8f7b9a17 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r 02ee8f7b9a17 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r bae71e582148 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+152 lines, -14 lines)			Patch
	M	src/pkg/runtime/proc.c	View	1 2 3 4	8 chunks	+144 lines, -14 lines	0 comments	Download
	M	src/pkg/runtime/runtime.h	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 3 months ago (2013-02-27 19:00:30 UTC) #1

rsc

LGTM https://codereview.appspot.com/7397061/diff/8001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/7397061/diff/8001/src/pkg/runtime/proc.c#newcode75 src/pkg/runtime/proc.c:75: P p; // temporal what does temporal mean? ...

12 years, 3 months ago (2013-02-27 19:04:44 UTC) #2

dvyukov

On 2013/02/27 19:04:44, rsc wrote: > LGTM > > https://codereview.appspot.com/7397061/diff/8001/src/pkg/runtime/proc.c > File src/pkg/runtime/proc.c (right): > ...

12 years, 3 months ago (2013-02-27 19:16:27 UTC) #3

dvyukov

12 years, 3 months ago (2013-02-27 19:18:13 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=e0b23d56fd6a ***

runtime: more changes in preparation to the new scheduler
add per-P cache of dead G's
add global runnable queue (not used for now)
add list of idle P's (not used for now)

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7397061

Expand All Messages | Collapse All Messages