code review 7397059: cmd/go: do not print GCC environment variables on Plan 9

cmd/go: do not print GCC environment variables on Plan 9

[ality, 2013-02-26 10:00:08]

Hello seed@mail.nanosouffle.net, rminnich@gmail.com (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2013-02-26 15:17:51]

https://codereview.appspot.com/7397059/diff/4001/src/cmd/go/env.go
File src/cmd/go/env.go (right):

https://codereview.appspot.com/7397059/diff/4001/src/cmd/go/env.go#newcode54
src/cmd/go/env.go:54: env = append(env, extra...)
how about just
env = append(envVar{"CC", xxx})
env = append(envVar("GOGCFLAGS", xxx})

[minux1, 2013-02-26 15:33:41]

https://codereview.appspot.com/7397059/diff/4001/src/cmd/go/env.go
File src/cmd/go/env.go (right):

https://codereview.appspot.com/7397059/diff/4001/src/cmd/go/env.go#newcode49
src/cmd/go/env.go:49: if runtime.GOOS != "plan9" {
i think it should use goos != "plan9".

[ality, 2013-02-26 15:51:26]

Hello seed@mail.nanosouffle.net, rminnich@gmail.com, r@golang.org,
minux.ma@gmail.com (cc: golang-dev@googlegroups.com),

Please take another look.

[minux1, 2013-02-26 16:07:57]

LGTM.

https://codereview.appspot.com/7397059/diff/3002/src/cmd/go/env.go
File src/cmd/go/env.go (right):

https://codereview.appspot.com/7397059/diff/3002/src/cmd/go/env.go#newcode51
src/cmd/go/env.go:51: env = append(env, envVar{"GOGCCFLAGS",
strings.Join(b.gccCmd(".")[3:], " ")})
the line is a bit too long IMO. do you mind make it:
cmd := b.gccCmd(".")
env = append(env, envVar{"CC", cmd[0]})
env = append(env, envVar{"GOGCCFLAGS", strings.Join(cmd[3:], " ")})

[r, 2013-02-26 16:16:19]

LGTM, with minux's suggestion applied

[ality, 2013-02-26 16:34:59]

*** Submitted as https://code.google.com/p/go/source/detail?r=b2cf2bf50e1f ***

cmd/go: do not print GCC environment variables on Plan 9

R=seed, rminnich, r, minux.ma
CC=golang-dev
https://codereview.appspot.com/7397059