Issue 7397052: code review 7397052: crypto/rsa: fix infinite loop in GenerateMultiPrimeKey ...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7397052: code review 7397052: crypto/rsa: fix infinite loop in GenerateMultiPrimeKey ... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by remyoudompheng

Modified:
13 years, 3 months ago

Reviewers:

CC:
agl1, golang-dev

Visibility:
Public.

Description

crypto/rsa: fix infinite loop in GenerateMultiPrimeKey for large nprimes The heuristics for BitLen of a product of randomly generated primes are wrong, and the generated candidates never match the required size for nprimes > 10. This corner case is not expected to be used in practice.

Patch Set 1 #

Patch Set 2 : diff -r 083759101bc9 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 083759101bc9 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 083759101bc9 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 655b43c97d76 https://go.googlecode.com/hg/ #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -6 lines)			Patch
	M	src/pkg/crypto/rsa/rsa.go	View	1 2 3	2 chunks	+17 lines, -2 lines	0 comments	Download
	M	src/pkg/crypto/rsa/rsa_test.go	View	1	3 chunks	+22 lines, -4 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

remyoudompheng

Hello agl@chromium.org, golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

13 years, 3 months ago (2013-02-22 09:56:09 UTC) #1

remyoudompheng

On 2013/02/22 22:57:29, rsc wrote: <empty string> What is the meaning of the empty comment?

13 years, 3 months ago (2013-02-24 15:16:18 UTC) #3

minux1

On 2013/02/24 15:16:18, remyoudompheng wrote: > On 2013/02/22 22:57:29, rsc wrote: > <empty string> > ...

13 years, 3 months ago (2013-02-24 15:19:03 UTC) #4

agl1

LGTM. (Although nprimes >= 7 is basically always a bad idea based on the estimates ...

13 years, 3 months ago (2013-02-24 15:50:16 UTC) #5

remyoudompheng

13 years, 3 months ago (2013-02-24 16:19:19 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=886c91b4ae3c ***

crypto/rsa: fix infinite loop in GenerateMultiPrimeKey for large nprimes

The heuristics for BitLen of a product of randomly generated primes
are wrong, and the generated candidates never match the required
size for nprimes > 10. This corner case is not expected to be used in
practice.

R=agl
CC=golang-dev
https://codereview.appspot.com/7397052

Expand All Messages | Collapse All Messages