code review 7396060: net: pass tests on Plan 9

net: pass tests on Plan 9

Ignore problematic tests and un-ignore one
we can now pass.

[akumar, 2013-02-26 00:52:59]

Hello rsc@golang.org, rminnich@gmail.com, ality@pbrane.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-02-26 01:00:13]

LGTM modulo one case of t.Logf; return

https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go
File src/pkg/net/net_test.go (right):

https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go#newc...
src/pkg/net/net_test.go:177: case "plan9":
t.Skipf("skipping test on %q", runtime.GOOS)

[akumar, 2013-02-26 01:10:43]

PTAL.

https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go
File src/pkg/net/net_test.go (right):

https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go#newc...
src/pkg/net/net_test.go:177: case "plan9":
On 2013/02/26 01:00:13, dfc wrote:
> t.Skipf("skipping test on %q", runtime.GOOS)

Done.

[bradfitz, 2013-02-26 01:16:29]

LGTM but I'd prefer issues to be filed for the known problems, and make the
comments or Skips reference the issue numbers.

On Mon, Feb 25, 2013 at 5:10 PM, <seed@mail.nanosouffle.net> wrote:

> PTAL.
>
>
>
> https://codereview.appspot.**com/7396060/diff/5001/src/pkg/**
>
net/net_test.go<https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go>
> File src/pkg/net/net_test.go (right):
>
> https://codereview.appspot.**com/7396060/diff/5001/src/pkg/**
>
net/net_test.go#newcode177<https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go#newcode177>
> src/pkg/net/net_test.go:177: case "plan9":
> On 2013/02/26 01:00:13, dfc wrote:
>
>> t.Skipf("skipping test on %q", runtime.GOOS)
>>
>
> Done.
>
>
>
https://codereview.appspot.**com/7396060/<https://codereview.appspot.com/7396...
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>
>
>

[akumar, 2013-02-26 01:25:04]

The issues are a bit fundamental: we don't support deadlines,
and the kernel code doesn't close a connection based upon
the ref count on fds. It seems that these things will have to
first be considered from the Plan 9 side of things.


On 26 February 2013 01:16, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> LGTM but I'd prefer issues to be filed for the known problems, and make the
> comments or Skips reference the issue numbers.
>
> On Mon, Feb 25, 2013 at 5:10 PM, <seed@mail.nanosouffle.net> wrote:
>>
>> PTAL.
>>
>>
>>
>> https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go
>> File src/pkg/net/net_test.go (right):
>>
>>
>>
https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go#newc...
>> src/pkg/net/net_test.go:177: case "plan9":
>> On 2013/02/26 01:00:13, dfc wrote:
>>>
>>> t.Skipf("skipping test on %q", runtime.GOOS)
>>
>>
>> Done.
>>
>>
>> https://codereview.appspot.com/7396060/
>>
>> --
>>
>> ---You received this message because you are subscribed to the Google
>> Groups "golang-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to golang-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>

[bradfitz, 2013-02-26 01:26:25]

So file one bug.

"plan9: networking is incomplete"

Then you can have a whole log of details, which is easier to reference and
mark fixed compared to email.


On Mon, Feb 25, 2013 at 5:24 PM, Akshat Kumar <seed@mail.nanosouffle.net>wrote:

> The issues are a bit fundamental: we don't support deadlines,
> and the kernel code doesn't close a connection based upon
> the ref count on fds. It seems that these things will have to
> first be considered from the Plan 9 side of things.
>
>
> On 26 February 2013 01:16, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> > LGTM but I'd prefer issues to be filed for the known problems, and make
> the
> > comments or Skips reference the issue numbers.
> >
> > On Mon, Feb 25, 2013 at 5:10 PM, <seed@mail.nanosouffle.net> wrote:
> >>
> >> PTAL.
> >>
> >>
> >>
> >>
> https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go
> >> File src/pkg/net/net_test.go (right):
> >>
> >>
> >>
>
https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go#newc...
> >> src/pkg/net/net_test.go:177: case "plan9":
> >> On 2013/02/26 01:00:13, dfc wrote:
> >>>
> >>> t.Skipf("skipping test on %q", runtime.GOOS)
> >>
> >>
> >> Done.
> >>
> >>
> >> https://codereview.appspot.com/7396060/
> >>
> >> --
> >>
> >> ---You received this message because you are subscribed to the Google
> >> Groups "golang-dev" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
> an
> >> email to golang-dev+unsubscribe@googlegroups.com.
> >> For more options, visit https://groups.google.com/groups/opt_out.
> >>
> >>
> >
>

[akumar, 2013-02-26 01:28:52]

Sounds good. Will do.

On 26 February 2013 01:26, Brad Fitzpatrick <bradfitz@golang.org> wrote:
> So file one bug.
>
> "plan9: networking is incomplete"
>
> Then you can have a whole log of details, which is easier to reference and
> mark fixed compared to email.
>
>
> On Mon, Feb 25, 2013 at 5:24 PM, Akshat Kumar <seed@mail.nanosouffle.net>
> wrote:
>>
>> The issues are a bit fundamental: we don't support deadlines,
>> and the kernel code doesn't close a connection based upon
>> the ref count on fds. It seems that these things will have to
>> first be considered from the Plan 9 side of things.
>>
>>
>> On 26 February 2013 01:16, Brad Fitzpatrick <bradfitz@golang.org> wrote:
>> > LGTM but I'd prefer issues to be filed for the known problems, and make
>> > the
>> > comments or Skips reference the issue numbers.
>> >
>> > On Mon, Feb 25, 2013 at 5:10 PM, <seed@mail.nanosouffle.net> wrote:
>> >>
>> >> PTAL.
>> >>
>> >>
>> >>
>> >>
>> >> https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go
>> >> File src/pkg/net/net_test.go (right):
>> >>
>> >>
>> >>
>> >>
https://codereview.appspot.com/7396060/diff/5001/src/pkg/net/net_test.go#newc...
>> >> src/pkg/net/net_test.go:177: case "plan9":
>> >> On 2013/02/26 01:00:13, dfc wrote:
>> >>>
>> >>> t.Skipf("skipping test on %q", runtime.GOOS)
>> >>
>> >>
>> >> Done.
>> >>
>> >>
>> >> https://codereview.appspot.com/7396060/
>> >>
>> >> --
>> >>
>> >> ---You received this message because you are subscribed to the Google
>> >> Groups "golang-dev" group.
>> >> To unsubscribe from this group and stop receiving emails from it, send
>> >> an
>> >> email to golang-dev+unsubscribe@googlegroups.com.
>> >> For more options, visit https://groups.google.com/groups/opt_out.
>> >>
>> >>
>> >
>
>

[rminnich, 2013-02-28 06:18:05]

*** Submitted as https://code.google.com/p/go/source/detail?r=641413cbc3fb ***

net: pass tests on Plan 9

Ignore problematic tests and un-ignore one
we can now pass.

R=rsc, rminnich, ality, dave, bradfitz
CC=golang-dev
https://codereview.appspot.com/7396060

Committer: Ron Minnich <rminnich@gmail.com>