Issue 7396055: environs: change StartInstance
Descriptionenvirons: change StartInstance
Dropped:
* tools, because it's up to the environ to pick the correct tools
* stateinfo/apiinfo, because the environ already knows them
Added:
* series, because the environ needs to know this
* agent password, because that's the one relevant bit of the supplied info
Also put the params into a struct, because I know for sure we'll be adding a
Constraints param and I have no interest in rewriting all these calls again
when the vast majority of them are not remotely relevant to constraints; and
I'm not *totally* certain that that will be the last param, anyway.
In making this work, any machine started by the provisioner/firewaller tests
had to be started with a series with available tools on the dummy provider;
ie, version.Current.Series. Similarly, the various environs tests -- apart
from the one testing bootstrap with non-native default-series -- all demand
the current version's series because those tools are always set up to be
available.
Other than this, I have tried to be minimally invasive; this has somewhat
harmed the clarity of the intersection between Bootstrap and StartInstance
in ec2 and openstack, but that's due a rework for constraints, anyway.
https://code.launchpad.net/~fwereade/juju-core/environs-unscrew-startinstance/+merge/150198
(do not edit description out of merge proposal)
Patch Set 1 #
MessagesTotal messages: 1
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
