Namespace restricted route matching

Namespace restricted route matching

Allow routes to additionally specify a namespace attribute. When
no route is specified the _nsRouter.defaultRoute is assumed.

https://code.launchpad.net/~bcsaller/juju-gui/namespace-matching/+merge/149912

(do not edit description out of merge proposal)

[bcsaller, 2013-02-21 19:15:27]

Please take a look.

[jeff.pihach, 2013-02-21 19:26:33]

Thanks, this looks like exactly what we were talking about, good work!

Land as is

[gary.poster, 2013-02-21 20:23:44]

LGTM, thank you.

[gary.poster, 2013-02-21 22:28:34]

LGTM as long as you address the concern I raised, one way or another (including
telling me I am wrong :-) ).

https://codereview.appspot.com/7396050/diff/9001/app/app.js
File app/app.js (right):

https://codereview.appspot.com/7396050/diff/9001/app/app.js#newcode1114
app/app.js:1114: *   namespace  attribute is specified.
That's not quite true, as I understand the code.  If no namespace attribute is
specified, the route will always will be considered once for every request, and
will match all namespaces.  That's subtly but importantly different, I think. 
If I go to /:not-the-default-namespace:/foo then the paths are [default
namespace]: /, ":not-the-default-namespace:": /foo.  If I have a registered path
of /foo without a namespace, it will match, yeah?  What you describe in text
might be better and easier to reason about, but if so, I think you need to
change the logic in the match method.

[bcsaller, 2013-02-22 03:14:26]

On 2013/02/21 22:28:34, gary.poster wrote:
> LGTM as long as you address the concern I raised, one way or another
(including
> telling me I am wrong :-) ).
> 
> https://codereview.appspot.com/7396050/diff/9001/app/app.js
> File app/app.js (right):
> 
> https://codereview.appspot.com/7396050/diff/9001/app/app.js#newcode1114
> app/app.js:1114: *   namespace  attribute is specified.
> That's not quite true, as I understand the code.  If no namespace attribute is
> specified, the route will always will be considered once for every request,
and
> will match all namespaces.  That's subtly but importantly different, I think. 
> If I go to /:not-the-default-namespace:/foo then the paths are [default
> namespace]: /, ":not-the-default-namespace:": /foo.  If I have a registered
path
> of /foo without a namespace, it will match, yeah?  What you describe in text
> might be better and easier to reason about, but if so, I think you need to
> change the logic in the match method.

The existing behavior matched routes in any namespace, I was trying to preserve
that behavior but nothing depended on it so I've simplified the rules. If

route.namespace = defaultNamespace if undefined
match w/o namespace assumes defaultNamespace.

[bcsaller, 2013-02-22 03:29:36]

*** Submitted:

Namespace restricted route matching

Allow routes to additionally specify a namespace attribute. When
no route is specified the _nsRouter.defaultRoute is assumed.

R=jeff.pihach, gary.poster
CC=
https://codereview.appspot.com/7396050