Issue 7395059: code review 7395059: cmd/dist: instruct the user to bind $GOBIN on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7395059: code review 7395059: cmd/dist: instruct the user to bind $GOBIN on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by ality

Modified:
11 years, 11 months ago

Reviewers:
akumar, rminnich, r

CC:
akumar, rminnich, bradfitz, r, golang-dev

Visibility:
Public.

Description

cmd/dist: instruct the user to bind $GOBIN on Plan 9

Patch Set 2 : diff -r 988d73fb1a18 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 988d73fb1a18 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r b766c6f23b62 https://code.google.com/p/go/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -10 lines)			Patch
	M	src/cmd/dist/build.c	View	1 2 3	2 chunks	+23 lines, -10 lines	0 comments	Download

Messages

Total messages: 10

Expand All Messages | Collapse All Messages

ality

Hello seed@mail.nanosouffle.net, rminnich@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 2 months ago (2013-02-26 18:14:04 UTC) #1

akumar

https://codereview.appspot.com/7395059/diff/3002/src/cmd/dist/build.c File src/cmd/dist/build.c (right): https://codereview.appspot.com/7395059/diff/3002/src/cmd/dist/build.c#newcode1596 src/cmd/dist/build.c:1596: // TODO(ality): parse /proc/$pid/ns to see if this message ...

12 years, 2 months ago (2013-02-26 18:34:01 UTC) #2

ality

Hello seed@mail.nanosouffle.net, rminnich@gmail.com (cc: golang-dev@googlegroups.com), Please take another look.

12 years, 2 months ago (2013-02-28 15:40:36 UTC) #3

akumar

+r bradfitz Hoping he can provide a final style & sanity check. Thanks, Akshat

12 years, 2 months ago (2013-03-12 22:47:24 UTC) #6

rminnich

12 years, 2 months ago (2013-03-15 04:04:28 UTC) #10

*** Submitted as https://code.google.com/p/go/source/detail?r=0a73c425cd39 ***

cmd/dist: instruct the user to bind $GOBIN on Plan 9

R=seed, rminnich, bradfitz, r
CC=golang-dev
https://codereview.appspot.com/7395059

Committer: Ron Minnich <rminnich@gmail.com>

Expand All Messages | Collapse All Messages