Issue 7395054: code review 7395054: cmd/gc: fix corruption in export of &T{} literals.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7395054: code review 7395054: cmd/gc: fix corruption in export of &T{} literals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 2 months ago by remyoudompheng

Modified:
12 years, 2 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/gc: fix corruption in export of &T{} literals. Composite literals using the &T{} form were incorrectly exported, leading to weird errors at import time. Fixes issue 4879.

Patch Set 1 #

Patch Set 2 : diff -r 5b495d0aefcf https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 5b495d0aefcf https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 37a172cbde23 https://go.googlecode.com/hg/ #

Created: 12 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -4 lines)			Patch
M	src/cmd/gc/fmt.c	View	1 2 3	4 chunks	+6 lines, -2 lines	0 comments	Download
M	src/cmd/gc/typecheck.c	View	1 2 3	2 chunks	+4 lines, -2 lines	0 comments	Download
A	test/fixedbugs/issue4879.go	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue4879.dir/a.go	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
A	test/fixedbugs/issue4879.dir/b.go	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

remyoudompheng

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

12 years, 2 months ago (2013-02-24 15:01:06 UTC) #1

rsc

LGTM I'm glad you managed to get this working. I tried and felt like I ...

12 years, 2 months ago (2013-02-25 21:55:53 UTC) #2

remyoudompheng

12 years, 2 months ago (2013-02-25 23:43:43 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=e73800eb2b00 ***

cmd/gc: fix corruption in export of &T{} literals.

Composite literals using the &T{} form were incorrectly
exported, leading to weird errors at import time.

Fixes issue 4879.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7395054

Expand All Messages | Collapse All Messages