Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(430)

Issue 7395050: code review 7395050: cmd/6g, cmd/8g: switch to DX for indirect call block (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by rsc
Modified:
12 years ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

cmd/6g, cmd/8g: switch to DX for indirect call block runtime: add context argument to gogocall Too many other things use AX, and at least one (stack zeroing) cannot be moved onto a different register. Use the less special DX instead. Preparation for step 2 of http://golang.org/s/go11func. Nothing interesting here, just split out so that we can see it's correct before moving on.

Patch Set 1 #

Patch Set 2 : diff -r 1852ee47001a https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 1852ee47001a https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 083759101bc9 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -33 lines) Patch
M src/cmd/6g/ggen.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8g/ggen.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/cmd/8l/pass.c View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/pkg/runtime/asm_386.s View 1 4 chunks +16 lines, -13 lines 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 4 chunks +14 lines, -11 lines 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/stack.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years ago (2013-02-22 15:47:52 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=237f213fc927 *** cmd/6g, cmd/8g: switch to DX for indirect call block runtime: ...
12 years ago (2013-02-22 15:47:59 UTC) #2
ken3
12 years ago (2013-02-22 17:36:15 UTC) #3
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b