Issue 7395045: code review 7395045: unicode: use new Scanner interface in table creation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7395045: code review 7395045: unicode: use new Scanner interface in table creation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by r

Modified:
12 years, 3 months ago

Reviewers:

CC:
mpvl, golang-dev

Visibility:
Public.

Description

unicode: use new Scanner interface in table creation Update norm and local/collate as well.

Patch Set 1 #

Patch Set 2 : diff -r f685026a2d38 https://code.google.com/p/go #

Patch Set 3 : diff -r 0e8fe3999864 https://code.google.com/p/go #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -91 lines)			Patch
M	src/pkg/exp/locale/collate/maketables.go	View		2 chunks	+6 lines, -11 lines	0 comments	Download
M	src/pkg/exp/locale/collate/regtest.go	View		2 chunks	+6 lines, -9 lines	0 comments	Download
M	src/pkg/exp/norm/maketables.go	View		5 chunks	+18 lines, -29 lines	0 comments	Download
M	src/pkg/exp/norm/normregtest.go	View		4 chunks	+8 lines, -12 lines	0 comments	Download
M	src/pkg/unicode/maketables.go	View	1	6 chunks	+21 lines, -30 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello mpvl@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-02-20 20:59:38 UTC) #1

12 years, 3 months ago (2013-02-21 18:47:32 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=347f4997aab6 ***

unicode: use new Scanner interface in table creation
Update norm and local/collate as well.

R=mpvl
CC=golang-dev
https://codereview.appspot.com/7395045

Expand All Messages | Collapse All Messages