Issue 7394047: code review 7394047: cmd/dist: avoid using %ebx on i386.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7394047: code review 7394047: cmd/dist: avoid using %ebx on i386. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 9 months ago by minux1

Modified:
12 years, 9 months ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/dist: avoid using %ebx on i386. Or gcc (-fPIC) will complain: cmd/dist/unix.c: In function ‘cansse2’ cmd/dist/unix.c:774: error: can't find a register in class ‘BREG’ while reloading ‘asm’ cmd/dist/unix.c:774: error: ‘asm’ operand has impossible constraints This affects bootstrapping on native Darwin/386 where all code is compiled with -fPIC.

Patch Set 1 #

Patch Set 2 : diff -r 526fb7125a2f https://code.google.com/p/go/ #

Patch Set 3 : diff -r 526fb7125a2f https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5b495d0aefcf https://code.google.com/p/go/ #

Created: 12 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/cmd/dist/unix.c	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years, 9 months ago (2013-02-23 09:56:01 UTC) #1

minux1

12 years, 9 months ago (2013-02-24 14:46:05 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d7ae1953ef1b ***

cmd/dist: avoid using %ebx on i386.
Or gcc (-fPIC) will complain:
cmd/dist/unix.c: In function ‘cansse2’
cmd/dist/unix.c:774: error: can't find a register in class ‘BREG’ while
reloading ‘asm’
cmd/dist/unix.c:774: error: ‘asm’ operand has impossible constraints

This affects bootstrapping on native Darwin/386 where all code is
compiled with -fPIC.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7394047

Expand All Messages | Collapse All Messages