code review 7393063: cmd/go: fix "go run" cgo source when cgo is disabled

cmd/go: fix "go run" cgo source when cgo is disabled
also move a cgo-depend test to appropriate source file in runtime.

[minux1, 2013-02-25 23:20:11]

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go/

[dave_cheney.net, 2013-02-26 00:03:34]

LGTM assuming it fixes
http://build.golang.org/log/c6359bba20cfd944671ffab8c0fbf8f8264dd589

https://codereview.appspot.com/7393063/diff/6001/src/cmd/go/run.go
File src/cmd/go/run.go (right):

https://codereview.appspot.com/7393063/diff/6001/src/cmd/go/run.go#newcode74
src/cmd/go/run.go:74: fatalf("go run: no suitable source file (check build tags
or filename?)")
Not sure about the parethetised suggestions, maybe leave them out.

[minux1, 2013-02-26 00:11:17]

On Tue, Feb 26, 2013 at 8:03 AM, <dave@cheney.net> wrote:

> LGTM assuming it fixes
>
http://build.golang.org/log/**c6359bba20cfd944671ffab8c0fbf8**f8264dd589<http...

yes, it should fix it.

> https://codereview.appspot.**com/7393063/diff/6001/src/cmd/**
>
go/run.go#newcode74<https://codereview.appspot.com/7393063/diff/6001/src/cmd/go/run.go#newcode74>
> src/cmd/go/run.go:74: fatalf("go run: no suitable source file (check
> build tags or filename?)")
> Not sure about the parethetised suggestions, maybe leave them out.
>
i was thinking that the possible confusion when the user get this:
$ go run some.go
go run: no suitable source file
$ go run _another.go
no Go source files in /Users/minux//go/go2.hg/src

(if the paren. hint is acceptable, we probably could also add a hint for
the 2nd case)

it seems the 1st case will only happen if cgo is disabled while the files
use cgo,
so perhaps we can check for the problem explicitly.

[dave_cheney.net, 2013-02-26 00:16:44]

Personally I don't want to see people relying on go run too much. Its
job is to run simple one shot source files, and people already expect
too much from it now.

+ adg to see if he can offer a suggestion on the error message

On Tue, Feb 26, 2013 at 11:10 AM, minux <minux.ma@gmail.com> wrote:
>
> On Tue, Feb 26, 2013 at 8:03 AM, <dave@cheney.net> wrote:
>>
>> LGTM assuming it fixes
>> http://build.golang.org/log/c6359bba20cfd944671ffab8c0fbf8f8264dd589
>
> yes, it should fix it.
>>
>>
>> https://codereview.appspot.com/7393063/diff/6001/src/cmd/go/run.go#newcode74
>> src/cmd/go/run.go:74: fatalf("go run: no suitable source file (check
>> build tags or filename?)")
>> Not sure about the parethetised suggestions, maybe leave them out.
>
> i was thinking that the possible confusion when the user get this:
> $ go run some.go
> go run: no suitable source file
> $ go run _another.go
> no Go source files in /Users/minux//go/go2.hg/src
>
> (if the paren. hint is acceptable, we probably could also add a hint for the
> 2nd case)
>
> it seems the 1st case will only happen if cgo is disabled while the files
> use cgo,
> so perhaps we can check for the problem explicitly.

[minux1, 2013-02-26 00:23:38]

On Tue, Feb 26, 2013 at 8:16 AM, Dave Cheney <dave@cheney.net> wrote:

> Personally I don't want to see people relying on go run too much. Its
> job is to run simple one shot source files, and people already expect
> too much from it now.
>
I agree. If andrew also agrees with eliminating the hint, i will do so.

[minux1, 2013-02-26 16:42:12]

c: +adg.

[adg, 2013-02-26 22:01:10]

https://codereview.appspot.com/7393063/diff/15001/src/cmd/go/run.go
File src/cmd/go/run.go (right):

https://codereview.appspot.com/7393063/diff/15001/src/cmd/go/run.go#newcode74
src/cmd/go/run.go:74: fatalf("go run: no suitable source file (cgo disabled?)")
If we're going to give hints (and I have nothing against hints) then we should
give the correct hint; we have the information.

hint := "check build tags"
if buildContext.CgoDisabled {
  hint += ", cgo is disabled"
}
fatalf("go run: no suitable source file (%s)", hint)

[dave_cheney.net, 2013-02-26 22:57:50]

SGTM.

On Wed, Feb 27, 2013 at 9:01 AM,  <adg@golang.org> wrote:
>
> https://codereview.appspot.com/7393063/diff/15001/src/cmd/go/run.go
> File src/cmd/go/run.go (right):
>
> https://codereview.appspot.com/7393063/diff/15001/src/cmd/go/run.go#newcode74
> src/cmd/go/run.go:74: fatalf("go run: no suitable source file (cgo
> disabled?)")
> If we're going to give hints (and I have nothing against hints) then we
> should give the correct hint; we have the information.
>
> hint := "check build tags"
> if buildContext.CgoDisabled {
>   hint += ", cgo is disabled"
> }
> fatalf("go run: no suitable source file (%s)", hint)
>
> https://codereview.appspot.com/7393063/

[minux1, 2013-02-27 04:30:23]

PTAL.

[adg, 2013-02-27 04:41:50]

LGTM

[rsc, 2013-02-27 16:37:56]

LGTM

[minux1, 2013-02-28 08:07:45]

*** Submitted as https://code.google.com/p/go/source/detail?r=b766c6f23b62 ***

cmd/go: fix "go run" cgo source when cgo is disabled
also move a cgo-depend test to appropriate source file in runtime.

R=golang-dev, dave, adg, rsc
CC=golang-dev
https://codereview.appspot.com/7393063