Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 7393058: [google gcc-4_7] new module grouping method

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by xur
Modified:
7 years, 11 months ago
Reviewers:
tejohnson, davidxl, miles
CC:
gcc-patches_gcc.gnu.org
Base URL:
svn+ssh://gcc.gnu.org/svn/gcc/branches/google/gcc-4_7/
Visibility:
Public.

Patch Set 1 #

Total comments: 79

Patch Set 2 : [google gcc-4_7] new module grouping algorithm patchset2 #

Total comments: 12

Patch Set 3 : [google gcc-4_7] new module grouping method patchset3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1085 lines, -87 lines) Patch
M gcc/auto-profile.c View 1 1 chunk +1 line, -1 line 0 comments Download
M gcc/c-family/c-opts.c View 1 1 chunk +1 line, -1 line 0 comments Download
M gcc/coverage.c View 1 2 6 chunks +15 lines, -5 lines 0 comments Download
M gcc/gcov-dump.c View 1 1 chunk +15 lines, -5 lines 0 comments Download
M gcc/gcov-io.h View 1 2 chunks +8 lines, -2 lines 0 comments Download
M gcc/gcov-io.c View 1 1 chunk +1 line, -1 line 0 comments Download
M gcc/l-ipo.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gcc/params.def View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
M gcc/toplev.c View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gcc/tree-profile.c View 1 2 chunks +30 lines, -0 lines 0 comments Download
M libgcc/dyn-ipa.c View 1 2 35 chunks +985 lines, -72 lines 0 comments Download

Messages

Total messages: 8
xur
Hi, This is the patch that implements a new module grouping. It's based on module ...
7 years, 11 months ago (2013-02-25 19:19:23 UTC) #1
miles_gnu.org
xur@google.com (Rong Xu) writes: > - gcov_unsigned_t is_exported; > + gcov_unsigned_t flag; /* bit 0: ...
7 years, 11 months ago (2013-02-25 23:12:30 UTC) #2
davidxl
The coverage.c related patch is not uploaded properly. Will be reviewed seperately. David https://codereview.appspot.com/7393058/diff/1/gcc/gcov-dump.c File ...
7 years, 11 months ago (2013-02-26 00:49:17 UTC) #3
xur
https://codereview.appspot.com/7393058/diff/1/libgcc/dyn-ipa.c File libgcc/dyn-ipa.c (right): https://codereview.appspot.com/7393058/diff/1/libgcc/dyn-ipa.c#newcode77 libgcc/dyn-ipa.c:77: /* Used by new algo. This dyn_pointer_set only On ...
7 years, 11 months ago (2013-02-26 21:50:01 UTC) #4
davidxl
Can you upload the new patch set? David On Tue, Feb 26, 2013 at 1:50 ...
7 years, 11 months ago (2013-02-26 23:26:41 UTC) #5
xur
Just upload the new patch set to https://codereview.appspot.com/7393058/#ps8001 As we discussed offline, I added a ...
7 years, 11 months ago (2013-02-27 00:06:52 UTC) #6
davidxl
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c File libgcc/dyn-ipa.c (right): https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode235 libgcc/dyn-ipa.c:235: /* Return module_id. FUNC_GUID is the global unique id. ...
7 years, 11 months ago (2013-02-27 00:40:31 UTC) #7
xur
7 years, 11 months ago (2013-02-27 00:57:04 UTC) #8
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c
File libgcc/dyn-ipa.c (right):

https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode1212
libgcc/dyn-ipa.c:1212: mod_id = get_module_id_from_func_glob_uid (node->guid) -
1;
Send the wrong patch.
Actually. This should be
mod_id = get_module_id_from_func_glob_uid (node->guid);

On 2013/02/27 00:40:31, davidxl wrote:
> Change var name from mod_id to mod_idx

https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode1232
libgcc/dyn-ipa.c:1232: callee_mod_id
Same as above. -1 should be removed.

On 2013/02/27 00:40:31, davidxl wrote:
> --> callee_mod_idx

https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode1250
libgcc/dyn-ipa.c:1250: = get_module_info (callee_mod_id);
This is ok.

On 2013/02/27 00:40:31, davidxl wrote:
> Should be get_module_info (callee_mod_idx + 1).
> 
> You should carefully check to make sure NO interfaces takes idx as parameters,
> and no interface returns idx.

https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode2276
libgcc/dyn-ipa.c:2276: /* Dumper function for NODE.   M is the module id and F
is the function id.  */
On 2013/02/27 00:40:31, davidxl wrote:
> M is module_ident -1

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b