Issue 7393050: code review 7393050: reflect: stop using run-time code generation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7393050: code review 7393050: reflect: stop using run-time code generation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:

CC:
golang-dev, bradfitz

Visibility:
Public.

Description

reflect: stop using run-time code generation Step 3 of http://golang.org/s/go11func. Fixes issue 3736. Fixes issue 3738. Fixes issue 4081.

Patch Set 1 #

Patch Set 2 : diff -r 51f7d979c6e8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 51f7d979c6e8 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 51f7d979c6e8 https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 365c7549ba99 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -135 lines)			Patch
M	src/pkg/reflect/asm_386.s	View	1	1 chunk	+5 lines, -10 lines	0 comments	Download
M	src/pkg/reflect/asm_amd64.s	View	1	1 chunk	+5 lines, -10 lines	0 comments	Download
M	src/pkg/reflect/asm_arm.s	View	1 2 3	1 chunk	+3 lines, -7 lines	0 comments	Download
M	src/pkg/reflect/makefunc.go	View	1 2	2 chunks	+15 lines, -107 lines	0 comments	Download
M	src/pkg/reflect/value.go	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-02-22 20:11:27 UTC) #1

rsc

12 years ago (2013-02-22 20:24:03 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=9e847dd7689b ***

reflect: stop using run-time code generation

Step 3 of http://golang.org/s/go11func.

Fixes issue 3736.
Fixes issue 3738.
Fixes issue 4081.

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7393050

Expand All Messages | Collapse All Messages