Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2321)

Issue 7391051: juju: add NewConnFromState

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by rog
Modified:
11 years, 2 months ago
Reviewers:
dimitern, mp+150538, dave, TheMue
Visibility:
Public.

Description

juju: add NewConnFromState We want to perform this operation to make a Conn available to the API server. https://code.launchpad.net/~rogpeppe/juju-core/229-NewConnFromState/+merge/150538 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : juju: add NewConnFromState #

Patch Set 3 : juju: add NewConnFromState #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
A [revision details] View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M juju/conn.go View 1 2 1 chunk +19 lines, -0 lines 0 comments Download
M juju/conn_test.go View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7
rog
Please take a look.
11 years, 2 months ago (2013-02-26 11:55:38 UTC) #1
TheMue
LGTM
11 years, 2 months ago (2013-02-26 12:06:04 UTC) #2
dimitern
LGTM
11 years, 2 months ago (2013-02-26 12:16:02 UTC) #3
dave_cheney.net
On 2013/02/26 12:16:02, dimitern wrote: > LGTM What do you plan to use this for ...
11 years, 2 months ago (2013-02-27 05:45:47 UTC) #4
rog
On 27 February 2013 05:45, <dave@cheney.net> wrote: > On 2013/02/26 12:16:02, dimitern wrote: >> >> ...
11 years, 2 months ago (2013-02-27 10:34:04 UTC) #5
dave_cheney.net
Nope. LGTM. On Wed, Feb 27, 2013 at 9:34 PM, roger peppe <rogpeppe@gmail.com> wrote: > ...
11 years, 2 months ago (2013-03-02 03:56:43 UTC) #6
rog
11 years, 2 months ago (2013-03-04 16:11:13 UTC) #7
*** Submitted:

juju: add NewConnFromState

We want to perform this operation to make
a Conn available to the API server.

R=TheMue, dimitern, dfc
CC=
https://codereview.appspot.com/7391051
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b