Issue 7391046: code review 7391046: exp/ssa: cross off a few remaining TODO issues.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7391046: code review 7391046: exp/ssa: cross off a few remaining TODO issues. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by adonovan

Modified:
12 years ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

exp/ssa: cross off a few remaining TODO issues. - append: nothing to do (nonsemantic change). - delete: now performs correct conversion (+ test). - emitCompare: nothing to do. - emitArith (shifts): nothing to do (+ test). - "banish untyped types": give up on that. - real, imag: now do correct conversions. - added comment to interp.go re zero-size values.

Patch Set 1 #

Patch Set 2 : diff -r ca83aeaa55e0 https://code.google.com/p/go/ #

Patch Set 3 : diff -r ca83aeaa55e0 https://code.google.com/p/go/ #

Patch Set 4 : diff -r ca83aeaa55e0 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r 1852ee47001a https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -21 lines)			Patch
M	src/pkg/exp/ssa/builder.go	View	1 2 3 4	4 chunks	+31 lines, -19 lines	0 comments	Download
M	src/pkg/exp/ssa/emit.go	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/pkg/exp/ssa/interp/interp.go	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/pkg/exp/ssa/interp/testdata/coverage.go	View	1 2 3 4	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-02-22 04:49:57 UTC) #1

gri

LGTM https://codereview.appspot.com/7391046/diff/8001/src/pkg/exp/ssa/interp/testdata/coverage.go File src/pkg/exp/ssa/interp/testdata/coverage.go (right): https://codereview.appspot.com/7391046/diff/8001/src/pkg/exp/ssa/interp/testdata/coverage.go#newcode324 src/pkg/exp/ssa/interp/testdata/coverage.go:324: // TODOreal, imag conversions space after TODO

12 years ago (2013-02-22 04:58:47 UTC) #2

adonovan

12 years ago (2013-02-22 05:09:23 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=083759101bc9 ***

exp/ssa: cross off a few remaining TODO issues.

- append: nothing to do (nonsemantic change).
- delete: now performs correct conversion (+ test).
- emitCompare: nothing to do.
- emitArith (shifts): nothing to do (+ test).
- "banish untyped types": give up on that.
- real, imag: now do correct conversions.
- added comment to interp.go re zero-size values.

R=gri
CC=golang-dev
https://codereview.appspot.com/7391046

Expand All Messages | Collapse All Messages