Issue 7391045: code review 7391045: cmd/5g, cmd/6g: fix node dump formats

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7391045: code review 7391045: cmd/5g, cmd/6g: fix node dump formats (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by rsc

Modified:
11 years, 1 month ago

Reviewers:

CC:
ken2, golang-dev

Visibility:
Public.

Description

cmd/5g, cmd/6g: fix node dump formats lvd changed the old %N to %+hN and these never got updated.

Patch Set 1 #

Patch Set 2 : diff -r 734059df2768 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 577ba2d07b0b https://go.googlecode.com/hg/ #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	src/cmd/5g/cgen.c	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
	M	src/cmd/6g/cgen.c	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 1 month ago (2013-02-21 17:53:24 UTC) #1

rsc

11 years, 1 month ago (2013-02-21 17:53:29 UTC) #2

*** Submitted as https://code.google.com/p/go/source/detail?r=f6fd55a8c1b8 ***

cmd/5g, cmd/6g: fix node dump formats

lvd changed the old %N to %+hN and these
never got updated.

R=ken2
CC=golang-dev
https://codereview.appspot.com/7391045

Expand All Messages | Collapse All Messages