Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(367)

Issue 7390047: code review 7390047: runtime: better error from TestGcSys when gc is disabled (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by rsc
Modified:
12 years ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

runtime: better error from TestGcSys when gc is disabled

Patch Set 1 #

Patch Set 2 : diff -r f6fd55a8c1b8 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 43cc2ef77ca6 https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/pkg/runtime/gc_test.go View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
12 years ago (2013-02-21 18:22:32 UTC) #1
rsc
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
12 years ago (2013-02-21 18:22:37 UTC) #2
bradfitz
why not t.Skip? On Thu, Feb 21, 2013 at 10:22 AM, <rsc@golang.org> wrote: > Hello ...
12 years ago (2013-02-21 18:23:40 UTC) #3
rsc
running tests with GOGC=off is not a mode i want to actively support. i just ...
12 years ago (2013-02-21 18:24:45 UTC) #4
bradfitz
LGTM On Thu, Feb 21, 2013 at 10:24 AM, Russ Cox <rsc@golang.org> wrote: > running ...
12 years ago (2013-02-21 18:30:07 UTC) #5
rsc
12 years ago (2013-02-21 18:30:36 UTC) #6
*** Submitted as https://code.google.com/p/go/source/detail?r=ddf29de95e90 ***

runtime: better error from TestGcSys when gc is disabled

R=golang-dev, bradfitz
CC=golang-dev
https://codereview.appspot.com/7390047
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b