Issue 7389049: code review 7389049: build: do not set GOBIN on Plan 9

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7389049: code review 7389049: build: do not set GOBIN on Plan 9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by ality

Modified:
12 years ago

Reviewers:

CC:
akumar, rminnich, r, golang-dev

Visibility:
Public.

Description

build: do not set GOBIN on Plan 9 Also, I synced the rc files with changes that have been made to make.bash, etc.

Patch Set 2 : diff -r 512627a9cdb8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 512627a9cdb8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 512627a9cdb8 https://code.google.com/p/go/ #

Total comments: 3

Patch Set 5 : diff -r b2cf2bf50e1f https://code.google.com/p/go/ #

Patch Set 6 : diff -r b2cf2bf50e1f https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -16 lines)			Patch
M	src/all.rc	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/cmd/dist/plan9.c	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/make.rc	View	1 2 3 4	2 chunks	+13 lines, -7 lines	0 comments	Download
M	src/run.rc	View	1 2 3 4	1 chunk	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

ality

Hello seed@mail.nanosouffle.net, rminnich@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-02-26 10:05:46 UTC) #1

LGTM if plan 9 users agree https://codereview.appspot.com/7389049/diff/7001/src/make.rc File src/make.rc (right): https://codereview.appspot.com/7389049/diff/7001/src/make.rc#newcode30 src/make.rc:30: # to include ...

12 years ago (2013-02-26 15:20:26 UTC) #2

akumar

https://codereview.appspot.com/7389049/diff/7001/src/make.rc File src/make.rc (right): https://codereview.appspot.com/7389049/diff/7001/src/make.rc#newcode49 src/make.rc:49: bind -b $GOROOT/bin /bin We are not running any ...

12 years ago (2013-02-26 16:35:35 UTC) #3

ality

12 years ago (2013-02-26 17:25:59 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=a53009b89e69 ***

build: do not set GOBIN on Plan 9

Also, I synced the rc files with changes
that have been made to make.bash, etc.

R=seed, rminnich, r
CC=golang-dev
https://codereview.appspot.com/7389049

Expand All Messages | Collapse All Messages