Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(173)

Issue 7389043: code review 7389043: runtime: split minit() to mpreinit() and minit() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dvyukov
Modified:
12 years ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: split minit() to mpreinit() and minit() mpreinit() is called on the parent thread and with mcache (can allocate memory), minit() is called on the child thread and can not allocate memory.

Patch Set 1 #

Patch Set 2 : diff -r d2f4fe93c8d6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r d2f4fe93c8d6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d2f4fe93c8d6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r bfb45be43e2b https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 3391481b6373 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -13 lines) Patch
M src/pkg/runtime/proc.c View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M src/pkg/runtime/runtime.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M src/pkg/runtime/thread_darwin.c View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M src/pkg/runtime/thread_freebsd.c View 1 2 1 chunk +9 lines, -1 line 0 comments Download
M src/pkg/runtime/thread_linux.c View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M src/pkg/runtime/thread_netbsd.c View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M src/pkg/runtime/thread_openbsd.c View 1 2 1 chunk +9 lines, -2 lines 0 comments Download
M src/pkg/runtime/thread_plan9.c View 1 2 1 chunk +12 lines, -4 lines 0 comments Download
M src/pkg/runtime/thread_windows.c View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years ago (2013-02-20 16:53:02 UTC) #1
dvyukov
This is needed because not all threads will have mcache after start. Thread creation will ...
12 years ago (2013-02-20 16:54:26 UTC) #2
rsc
Please wait on this CL until my "running Go on non-Go threads" CL is in. ...
12 years ago (2013-02-20 16:59:06 UTC) #3
dvyukov
On Wed, Feb 20, 2013 at 8:59 PM, Russ Cox <rsc@golang.org> wrote: > Please wait ...
12 years ago (2013-02-20 17:12:40 UTC) #4
rsc
I have not tried it. I am still trying to unbreak my CL on Windows ...
12 years ago (2013-02-20 17:34:05 UTC) #5
dvyukov
ok On Wed, Feb 20, 2013 at 9:34 PM, Russ Cox <rsc@golang.org> wrote: > I ...
12 years ago (2013-02-20 17:42:16 UTC) #6
dvyukov
On 2013/02/20 17:42:16, dvyukov wrote: > ok > > > On Wed, Feb 20, 2013 ...
12 years ago (2013-02-21 05:52:21 UTC) #7
rsc
LGTM
12 years ago (2013-02-21 12:10:29 UTC) #8
dvyukov
12 years ago (2013-02-21 12:25:22 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=734059df2768 ***

runtime: split minit() to mpreinit() and minit()
mpreinit() is called on the parent thread and with mcache (can allocate memory),
minit() is called on the child thread and can not allocate memory.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7389043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b