Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(353)

Issue 7388049: code review 7388049: runtime: add cgocallback_gofunc that can call Go func value (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 3 months ago by rsc
Modified:
12 years, 3 months ago
Reviewers:
ken3
CC:
ken2, golang-dev
Visibility:
Public.

Description

runtime: add cgocallback_gofunc that can call Go func value For now, all the callbacks from C use top-level Go functions, so they use the equivalent C function pointer, and will continue to do so. But perhaps some day this will be useful for calling a Go func value (at least if the type is already known). More importantly, the Windows callback code needs to be able to use cgocallback_gofunc to call a Go func value. Should fix the Windows build.

Patch Set 1 #

Patch Set 2 : diff -r 9f1072c320da https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 9f1072c320da https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r a9bb6b6bce8b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -14 lines) Patch
M src/pkg/runtime/asm_386.s View 1 1 chunk +15 lines, -1 line 0 comments Download
M src/pkg/runtime/asm_amd64.s View 1 1 chunk +15 lines, -1 line 0 comments Download
M src/pkg/runtime/asm_arm.s View 1 1 chunk +15 lines, -1 line 0 comments Download
M src/pkg/runtime/callback_windows_386.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/callback_windows_amd64.c View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/cgocall.c View 1 2 chunks +3 lines, -5 lines 0 comments Download
M src/pkg/runtime/sys_windows_386.s View 1 1 chunk +1 line, -1 line 0 comments Download
M src/pkg/runtime/sys_windows_amd64.s View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 3
rsc
Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
12 years, 3 months ago (2013-02-22 21:08:55 UTC) #1
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=91778e3920ae *** runtime: add cgocallback_gofunc that can call Go func value For ...
12 years, 3 months ago (2013-02-22 21:08:59 UTC) #2
ken3
12 years, 3 months ago (2013-02-23 06:32:13 UTC) #3
Message was sent while issue was closed.
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b