Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(720)

Issue 7388043: code review 7388043: runtime: prepare for M's running w/o mcache (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by dvyukov
Modified:
12 years ago
Reviewers:
CC:
golang-dev, rsc
Visibility:
Public.

Description

runtime: prepare for M's running w/o mcache Can not happen ATM. In preparation for the new scheduler.

Patch Set 1 #

Patch Set 2 : diff -r dd18b993ba95 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r dd18b993ba95 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r d2f4fe93c8d6 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r d2f4fe93c8d6 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/runtime/panic.c View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
12 years ago (2013-02-20 16:21:12 UTC) #1
rsc
How will this be possible in the new scheduler? Doesn't every m allocate mcache very ...
12 years ago (2013-02-20 16:22:04 UTC) #2
dvyukov
In the new scheduler mcache sits in a separate P struct. P structs along with ...
12 years ago (2013-02-20 16:49:25 UTC) #3
rsc
LGTM
12 years ago (2013-02-20 16:58:04 UTC) #4
dvyukov
12 years ago (2013-02-20 17:18:04 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=592fa6bfc380 ***

runtime: prepare for M's running w/o mcache
Can not happen ATM. In preparation for the new scheduler.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7388043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b