Issue 7385055: code review 7385055: cmd/gc: don't emit type instructions for nonexisting locals

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7385055: code review 7385055: cmd/gc: don't emit type instructions for nonexisting locals (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by DMorsing

Modified:
12 years ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/gc: don't emit type instructions for nonexisting locals If all locals are optimized away, the type instructions would stay in the instruction stream. Call fixautoused to scrub the output. Fixes issue 4915.

Patch Set 1 #

Patch Set 2 : diff -r c28d9e5f42ff https://code.google.com/p/go/ #

Patch Set 3 : diff -r c28d9e5f42ff https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r ed56306fe497 https://code.google.com/p/go/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	src/cmd/gc/pgen.c	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

DMorsing

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-02-26 21:20:06 UTC) #1

rsc

LGTM https://codereview.appspot.com/7385055/diff/5001/src/cmd/gc/pgen.c File src/cmd/gc/pgen.c (right): https://codereview.appspot.com/7385055/diff/5001/src/cmd/gc/pgen.c#newcode212 src/cmd/gc/pgen.c:212: curfn->dcl = nil; please insert a comment before ...

12 years ago (2013-02-27 16:28:48 UTC) #2

DMorsing

12 years ago (2013-02-27 18:47:19 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=bae71e582148 ***

cmd/gc: don't emit type instructions for nonexisting locals

If all locals are optimized away, the type instructions would stay in the
instruction stream. Call fixautoused to scrub the output.

Fixes issue 4915.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7385055

Expand All Messages | Collapse All Messages