Issue 7385053: [1.14 only] http issue 162: Remove deprecated API from 1.13 [backwards incompatible]

Issue 7385053: [1.14 only] http issue 162: Remove deprecated API from 1.13 [backwards incompatible] (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by yanivi

Modified:
11 years, 2 months ago

Reviewers:
peleyal

CC:
ngmiceli, rmistry

Base URL:
https://code.google.com/p/google-http-java-client/

Visibility:
Public.

More Reviews

Description

http issue 162: Remove deprecated API from 1.13 [backwards incompatible]

Patch Set 2 : remove lots of obsolete upgrade warnings #

Total comments: 4

Patch Set 3 : javadoc fix #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+257 lines, -2783 lines)			Patch
M	clirr-ignored-differences.xml	View		3 chunks	+70 lines, -0 lines	0 comments	Download
M	google-http-client-appengine/src/main/java/com/google/api/client/extensions/appengine/http/UrlFetchTransport.java	View		2 chunks	+0 lines, -37 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpHeaders.java	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
R	google-http-client/src/main/java/com/google/api/client/http/HttpMethod.java	View		1 chunk	+0 lines, -29 lines	0 comments	Download
R	google-http-client/src/main/java/com/google/api/client/http/HttpParser.java	View		1 chunk	+0 lines, -48 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java	View		9 chunks	+1 line, -126 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpRequestFactory.java	View		1 chunk	+0 lines, -16 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java	View	1 2	2 chunks	+15 lines, -62 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/HttpTransport.java	View	1	2 chunks	+1 line, -164 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/LowLevelHttpResponse.java	View	1	2 chunks	+8 lines, -69 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/apache/ApacheHttpTransport.java	View	1	3 chunks	+0 lines, -58 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpTransport.java	View		1 chunk	+0 lines, -36 lines	0 comments	Download
R	google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpClient.java	View		1 chunk	+0 lines, -845 lines	0 comments	Download
R	google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpParser.java	View		1 chunk	+0 lines, -190 lines	0 comments	Download
R	google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpRequest.java	View		1 chunk	+0 lines, -256 lines	0 comments	Download
R	google-http-client/src/main/java/com/google/api/client/http/json/JsonHttpRequestInitializer.java	View		1 chunk	+0 lines, -55 lines	0 comments	Download
R	google-http-client/src/main/java/com/google/api/client/http/xml/XmlHttpParser.java	View		1 chunk	+0 lines, -177 lines	0 comments	Download
R	google-http-client/src/main/java/com/google/api/client/http/xml/atom/AtomParser.java	View		1 chunk	+0 lines, -57 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/json/GenericJson.java	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/json/Json.java	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/json/JsonFactory.java	View	1	4 chunks	+0 lines, -20 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/testing/http/MockHttpTransport.java	View		3 chunks	+0 lines, -55 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/testing/http/MockLowLevelHttpResponse.java	View		5 chunks	+30 lines, -1 line	0 comments	Download
A	google-http-client/src/main/java/com/google/api/client/testing/util/TestableByteArrayInputStream.java	View		1 chunk	+68 lines, -0 lines	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/testing/util/TestableByteArrayOutputStream.java	View		1 chunk	+1 line, -1 line	0 comments	Download
M	google-http-client/src/main/java/com/google/api/client/util/DateTime.java	View	1	1 chunk	+0 lines, -7 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java	View		2 chunks	+0 lines, -7 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java	View		9 chunks	+63 lines, -105 lines	0 comments	Download
M	google-http-client/src/test/java/com/google/api/client/http/javanet/NetHttpTransportTest.java	View		1 chunk	+0 lines, -6 lines	0 comments	Download
R	google-http-client/src/test/java/com/google/api/client/http/json/JsonHttpClientTest.java	View		1 chunk	+0 lines, -259 lines	0 comments	Download
R	google-http-client/src/test/java/com/google/api/client/http/json/JsonHttpRequestTest.java	View		1 chunk	+0 lines, -79 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

peleyal

LGTM with small fixes https://codereview.appspot.com/7385053/diff/3001/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java (right): https://codereview.appspot.com/7385053/diff/3001/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java#newcode464 google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java:464: * http://tools.ietf.org/html/rfc2616#section-4.3}, calling {@link #ignore()} ...

11 years, 2 months ago (2013-02-26 21:42:27 UTC) #2

yanivi

https://codereview.appspot.com/7385053/diff/3001/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java File google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java (right): https://codereview.appspot.com/7385053/diff/3001/google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java#newcode464 google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java:464: * http://tools.ietf.org/html/rfc2616#section-4.3}, calling {@link #ignore()} if {@code true}. On ...

11 years, 2 months ago (2013-02-27 15:11:14 UTC) #3

peleyal

11 years, 2 months ago (2013-02-27 15:35:22 UTC) #4

Message was sent while issue was closed.

On 2013/02/27 15:11:14, yanivi wrote:
>
https://codereview.appspot.com/7385053/diff/3001/google-http-client/src/main/...
> File
> google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java
> (right):
> 
>
https://codereview.appspot.com/7385053/diff/3001/google-http-client/src/main/...
>
google-http-client/src/main/java/com/google/api/client/http/HttpResponse.java:464:
> * http://tools.ietf.org/html/rfc2616#section-4.3%7D, calling {@link #ignore()}
if
> {@code true}.
> On 2013/02/26 21:42:27, peleyal wrote:
> > if {@code false}.
> 
> Done.
> 
>
https://codereview.appspot.com/7385053/diff/3001/google-http-client/src/test/...
> File
>
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java
> (right):
> 
>
https://codereview.appspot.com/7385053/diff/3001/google-http-client/src/test/...
>
google-http-client/src/test/java/com/google/api/client/http/HttpResponseTest.java:195:
> HttpStatusCodes.STATUS_CODE_NO_CONTENT,
> HttpStatusCodes.STATUS_CODE_NOT_MODIFIED, 102}) {
> On 2013/02/26 21:42:27, peleyal wrote:
> > (102) Don't you want to add that value as
> > HttpStatusCodes.STATUS_CODE_PROCESSING?
> 
> No, because it is not in the official HTTP spec:
> http://tools.ietf.org/html/rfc2616#section-10.1

OK. I saw it on wiki...

Expand All Messages | Collapse All Messages