Issue 7385051: code review 7385051: cmd/vet: fix printf test for unsafe Pointer

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7385051: code review 7385051: cmd/vet: fix printf test for unsafe Pointer (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by r

Modified:
12 years ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

cmd/vet: fix printf test for unsafe Pointer And fix test. Pointer to unsafe.Pointer tests nothing important... Also identify the incorrect type: go/types.Type is a Stringer. Also fix a couple of incorrect format verbs found by new printf checker, now that we can run it on more files.

Patch Set 1 #

Patch Set 2 : diff -r 81bda3810efb https://code.google.com/p/go #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)			Patch
M	src/cmd/vet/print.go	View	4 chunks	+11 lines, -6 lines	0 comments	Download
M	src/cmd/vet/test_print.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/sync/atomic/atomic_test.go	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-02-26 05:58:59 UTC) #1

12 years ago (2013-02-26 18:36:17 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=d3599a588213 ***

cmd/vet: fix printf test for unsafe Pointer
And fix test. Pointer to unsafe.Pointer tests nothing important...
Also identify the incorrect type: go/types.Type is a Stringer.

Also fix a couple of incorrect format verbs found by new printf checker,
now that we can run it on more files.

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7385051

Expand All Messages | Collapse All Messages