code review 73850043: net/http: eliminate defined-but-not-used var.

net/http: eliminate defined-but-not-used var.

gc does not report this as an error, but go/types does.
(I suspect that constructing a closure counts as a reference
to &all in gc's implementation).

This is not a tool bug, since the spec doesn't require
implementations to implement this check, but it does
illustrate that dialect variations are always a nuisance.

[adonovan, 2014-03-11 01:41:37]

Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com,
gri@golang.org, rsc@golang.org),

I'd like you to review this change to
https://code.google.com/p/go/

[rsc, 2014-03-11 02:00:08]

LGTM

my apologies

[bradfitz, 2014-03-11 02:03:07]

LGTM but could use := now for err
 On Mar 10, 2014 6:41 PM, <adonovan@google.com> wrote:

> Reviewers: bradfitz,
>
> Message:
> Hello bradfitz@golang.org (cc: golang-codereviews@googlegroups.com,
> gri@golang.org, rsc@golang.org),
>
> I'd like you to review this change to
> https://code.google.com/p/go/
>
>
> Description:
> net/http: eliminate defined-but-not-used var.
>
> gc does not report this as an error, but go/types does.
> (I suspect that constructing a closure counts as a reference
> to &all in gc's implementation).
>
> This is not a tool bug, since the spec doesn't require
> implementations to implement this check, but it does
> illustrate that dialect variations are always a nuisance.
>
> Please review this at https://codereview.appspot.com/73850043/
>
> Affected files (+1, -2 lines):
>   M src/pkg/net/http/client_test.go
>
>
> Index: src/pkg/net/http/client_test.go
> ===================================================================
> --- a/src/pkg/net/http/client_test.go
> +++ b/src/pkg/net/http/client_test.go
> @@ -886,11 +886,10 @@
>                 t.Fatal("handler never got /slow request")
>         }
>
> -       var all []byte
>         errc := make(chan error, 1)
>         go func() {
>                 var err error
> -               all, err = ioutil.ReadAll(res.Body)
> +               _, err = ioutil.ReadAll(res.Body)
>                 errc <- err
>                 res.Body.Close()
>         }()
>
>
>

[adonovan, 2014-03-11 02:22:52]

On 10 March 2014 22:03, Brad Fitzpatrick <bradfitz@golang.org> wrote:

> LGTM but could use := now for err
>

Done.

[adonovan, 2014-03-11 02:22:55]

*** Submitted as https://code.google.com/p/go/source/detail?r=226e832f800b ***

net/http: eliminate defined-but-not-used var.

gc does not report this as an error, but go/types does.
(I suspect that constructing a closure counts as a reference
to &all in gc's implementation).

This is not a tool bug, since the spec doesn't require
implementations to implement this check, but it does
illustrate that dialect variations are always a nuisance.

LGTM=rsc, bradfitz
R=bradfitz
CC=golang-codereviews, gri, rsc
https://codereview.appspot.com/73850043

[gobot, 2014-03-11 02:28:25]

This CL appears to have broken the darwin-386-cheney builder.

[adonovan, 2014-03-11 02:32:14]

On 2014/03/11 02:28:25, gobot wrote:
> This CL appears to have broken the darwin-386-cheney builder.

"Appears to" being the operative words.