I'm not sure how a unit test should be added for this issue. I noticed ...
11 years, 6 months ago
(2013-02-22 20:19:09 UTC)
#1
I'm not sure how a unit test should be added for this issue. I noticed this when
working with many threads and receiving some invalid responses from a server
which was triggering a httplib.BadStatusLine exception.
Please let me know if there is a reason not to close the connection in this
case; it seems odd that it's the only place where it is not closed.
The open issue for this is:
http://code.google.com/p/httplib2/issues/detail?id=248
LGTM Committed in https://code.google.com/p/httplib2/source/detail?r=fae31589d6cc7d5ea4184bd515dd818900ec7f5a On 2013/02/22 20:19:09, schrierc wrote: > I'm not sure how a ...
11 years, 6 months ago
(2013-02-25 15:17:01 UTC)
#2
LGTM
Committed in
https://code.google.com/p/httplib2/source/detail?r=fae31589d6cc7d5ea4184bd515...
On 2013/02/22 20:19:09, schrierc wrote:
> I'm not sure how a unit test should be added for this issue. I noticed this
when
> working with many threads and receiving some invalid responses from a server
> which was triggering a httplib.BadStatusLine exception.
>
> Please let me know if there is a reason not to close the connection in this
> case; it seems odd that it's the only place where it is not closed.
>
> The open issue for this is:
> http://code.google.com/p/httplib2/issues/detail?id=248
Issue 7384055: Add missing call to conn.close() on Exception
Created 11 years, 6 months ago by schrierc
Modified 11 years, 6 months ago
Reviewers: jcgregorio
Base URL:
Comments: 0