Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3487)

Issue 7384055: Add missing call to conn.close() on Exception

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 2 months ago by schrierc
Modified:
11 years, 2 months ago
Reviewers:
jcgregorio
CC:
httlib2-dev_googlegroups.com
Visibility:
Public.

Description

Add missing call to conn.close() on Exception

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M python2/httplib2/__init__.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
schrierc
I'm not sure how a unit test should be added for this issue. I noticed ...
11 years, 2 months ago (2013-02-22 20:19:09 UTC) #1
jcgregorio
11 years, 2 months ago (2013-02-25 15:17:01 UTC) #2
LGTM

Committed in
https://code.google.com/p/httplib2/source/detail?r=fae31589d6cc7d5ea4184bd515...

On 2013/02/22 20:19:09, schrierc wrote:
> I'm not sure how a unit test should be added for this issue. I noticed this
when
> working with many threads and receiving some invalid responses from a server
> which was triggering a httplib.BadStatusLine exception.
> 
> Please let me know if there is a reason not to close the connection in this
> case; it seems odd that it's the only place where it is not closed.
> 
> The open issue for this is:
> http://code.google.com/p/httplib2/issues/detail?id=248
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b