Issue 7384054: code review 7384054: exp/ssa: fixed bug (typo) in findPromotedField.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7384054: code review 7384054: exp/ssa: fixed bug (typo) in findPromotedField. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by adonovan

Modified:
12 years ago

Reviewers:

CC:
gri, golang-dev

Visibility:
Public.

Description

exp/ssa: fixed bug (typo) in findPromotedField. By appending to the wrong (always empty) list, only the last anonymous field was being considered for promotion. Also: - eliminated "function-local NamedTypes" TODO; nothing to do. - fixed Function.DumpTo: printing of anon receivers was "( T)", now "(T)"; extracted writeSignature into own function. - eliminated blockNames function; thanks to BasicBlock.String, "%s" of []*BasicBlock is fine. - extracted buildReferrers into own function. exp/ssa can now build its own transitive closure.

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -66 lines)			Patch
M	src/pkg/exp/ssa/builder.go	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download
M	src/pkg/exp/ssa/func.go	View	1 2	5 chunks	+63 lines, -46 lines	0 comments	Download
M	src/pkg/exp/ssa/promote.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/exp/ssa/sanity.go	View	1	4 chunks	+2 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello gri@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

12 years ago (2013-02-22 15:51:51 UTC) #1

adonovan

12 years ago (2013-02-22 17:35:48 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ebebb95cff06 ***

exp/ssa: fixed bug (typo) in findPromotedField.

By appending to the wrong (always empty) list, only the last
anonymous field was being considered for promotion.

Also:
- eliminated "function-local NamedTypes" TODO; nothing to do.
- fixed Function.DumpTo: printing of anon receivers was "( T)",
  now "(T)"; extracted writeSignature into own function.
- eliminated blockNames function;
  thanks to BasicBlock.String, "%s" of []*BasicBlock is fine.
- extracted buildReferrers into own function.

exp/ssa can now build its own transitive closure.

R=gri
CC=golang-dev
https://codereview.appspot.com/7384054

Expand All Messages | Collapse All Messages