Issue 73840043: code review 73840043: path/filepath: fixed misaligned comment.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 73840043: code review 73840043: path/filepath: fixed misaligned comment.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by kayzhu

Modified:
11 years, 3 months ago

Reviewers:
bradfitz

CC:
golang-codereviews, bradfitz

Visibility:
Public.

Description

path/filepath: fixed misaligned comment. The comment for 'Clean' function is prepended with spaces instead of a single tab, resulting in visually misaligned comment in the generated documentation.

Patch Set 1 #

Patch Set 2 : diff -r 474703cfa0a7 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 602aa75d9daf https://code.google.com/p/go/ #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/path/filepath/path.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

kayzhu

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 3 months ago (2014-03-11 01:07:52 UTC) #1

bradfitz

11 years, 3 months ago (2014-03-11 21:34:18 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=ac22f24159cc ***

path/filepath: fixed misaligned comment.

The comment for 'Clean' function is prepended with spaces instead of
a single tab, resulting in visually misaligned comment in the generated
documentation.

LGTM=bradfitz
R=golang-codereviews, bradfitz
CC=golang-codereviews
https://codereview.appspot.com/73840043

Committer: Brad Fitzpatrick <bradfitz@golang.org>

Expand All Messages | Collapse All Messages