Issue 7383055: code review 7383055: cmd/ld: change GC_CALL to 32-bit relative address

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7383055: code review 7383055: cmd/ld: change GC_CALL to 32-bit relative address (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by rsc

Modified:
12 years ago

Reviewers:

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/ld: change GC_CALL to 32-bit relative address The current code uses 64-bit pc-relative on 64-bit systems, but in ELF linkers there is no such thing, so we cannot express this in a .o file. Change to 32-bit.

Patch Set 1 #

Patch Set 2 : diff -r 1e891021e069 https://go.googlecode.com/hg #

Patch Set 3 : diff -r 1e891021e069 https://go.googlecode.com/hg #

Patch Set 4 : diff -r 6b06c70f12ca https://go.googlecode.com/hg #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -23 lines)			Patch
	M	src/cmd/ld/data.c	View	1 2	2 chunks	+3 lines, -22 lines	0 comments	Download
	M	src/pkg/runtime/mgc0.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg

12 years ago (2013-02-26 22:46:34 UTC) #1

rsc

12 years ago (2013-02-27 03:43:01 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=0add1de89fe4 ***

cmd/ld: change GC_CALL to 32-bit relative address

The current code uses 64-bit pc-relative on 64-bit systems,
but in ELF linkers there is no such thing, so we cannot
express this in a .o file. Change to 32-bit.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/7383055

Expand All Messages | Collapse All Messages