Issue 7383053: code review 7383053: cmd/gc: fix mkbuiltin (gc -A always write all symbols t...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7383053: code review 7383053: cmd/gc: fix mkbuiltin (gc -A always write all symbols t... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by minux1

Modified:
12 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

cmd/gc: fix mkbuiltin (gc -A always write all symbols to export section) Regenerate cmd/gc/builtin.c. Fixes issue 4908.

Patch Set 1 #

Patch Set 2 : diff -r 08dc15884e88 https://code.google.com/p/go #

Patch Set 3 : diff -r 08dc15884e88 https://code.google.com/p/go #

Patch Set 4 : diff -r 408b088723fd https://code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+110 lines, -110 lines)			Patch
	M	src/cmd/gc/builtin.c	View	1	1 chunk	+108 lines, -109 lines	0 comments	Download
	M	src/cmd/gc/export.c	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

minux1

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

12 years, 3 months ago (2013-02-25 17:06:07 UTC) #1

minux1

12 years, 3 months ago (2013-02-25 19:15:14 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=4b16fb118e08 ***

cmd/gc: fix mkbuiltin (gc -A always write all symbols to export section)
Regenerate cmd/gc/builtin.c.
Fixes issue 4908.

R=rsc
CC=golang-dev
https://codereview.appspot.com/7383053

Expand All Messages | Collapse All Messages