Issue 7382045: code review 7382045: archive/tar: make test pass on setgid dirs

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7382045: code review 7382045: archive/tar: make test pass on setgid dirs (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by bradfitz

Modified:
12 years ago

Reviewers:
rsc

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

archive/tar: make test pass on setgid dirs Fixes issue 4867

Patch Set 1 #

Patch Set 2 : diff -r bfb45be43e2b https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r bfb45be43e2b https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r ad69f53ba310 https://go.googlecode.com/hg/ #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
		src/pkg/archive/tar/tar_test.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

12 years ago (2013-02-21 16:11:41 UTC) #1

bradfitz

*** Submitted as https://code.google.com/p/go/source/detail?r=dc41bc3036ce *** archive/tar: make test pass on setgid dirs Fixes issue 4867 ...

12 years ago (2013-02-21 22:00:08 UTC) #3

bradfitz

12 years ago (2013-02-21 22:16:52 UTC) #5

On Thu, Feb 21, 2013 at 2:00 PM, Russ Cox <rsc@golang.org> wrote:

> Why is the tar header including bits outside 0777? That seems wrong.
>

// Mode constants from the tar spec.

const (
        c_ISUID  = 04000   // Set uid

        c_ISGID  = 02000   // Set gid

        c_ISVTX  = 01000   // Save text (sticky bit)

        c_ISDIR  = 040000  // Directory

        c_ISFIFO = 010000  // FIFO

        c_ISREG  = 0100000 // Regular file

        c_ISLNK  = 0120000 // Symbolic link

        c_ISBLK  = 060000  // Block special file

        c_ISCHR  = 020000  // Character special file

        c_ISSOCK = 0140000 // Socket

)

Expand All Messages | Collapse All Messages