Landscape service menu integration

Landscape service menu integration

Service menu items appear if landscape tells us 
we need them.

https://code.launchpad.net/~bcsaller/juju-gui/landscape-service-menu/+merge/150689

(do not edit description out of merge proposal)

[bcsaller, 2013-02-27 02:46:17]

Please take a look.

[bcsaller, 2013-02-27 14:55:37]

Please take a look.

[jeff.pihach, 2013-02-27 15:55:52]

LGTM Thanks for the branch!

[goodspud, 2013-02-27 16:08:16]

LGTM Sign off from Design

[gary.poster, 2013-02-27 16:31:41]

LGTM with trivial, assuming you've QA'd to verify that the Landscape links do
hide when appropriate.

Thanks

Gary

https://codereview.appspot.com/7381060/diff/6001/app/templates/overview.handl...
File app/templates/overview.handlebars (right):

https://codereview.appspot.com/7381060/diff/6001/app/templates/overview.handl...
app/templates/overview.handlebars:9: <li class="landscape-reboot"><a
href="#">Machine Restart Needed</a></li>
I vote for consistency.  If we have the <a href="#"> for these two, let's have
them for the previous three as well, unless there's a reason not to.

https://codereview.appspot.com/7381060/diff/6001/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/7381060/diff/6001/app/views/topology/service.j...
app/views/topology/service.js:909: landscapeSecurity.show().one('a').set('href',
securityURL);
Why don't we need to hide these otherwise?  I'll QA it in a sec, so if it works,
nm, though I would like to understand.

[bcsaller, 2013-02-27 16:37:58]

Thanks for the review. 

Comments below, I think all your concerns are addressed. The tests around link
generation (prev branch) show that removing annotations has the proper effects.
This did test true in practice as well, though thats currently a little hard to
test as improv doesn't allow specific control over mutating these annotations at
runtime. I was able to remove units till the condition I was looking to test was
met. :-/

https://codereview.appspot.com/7381060/diff/6001/app/templates/overview.handl...
File app/templates/overview.handlebars (right):

https://codereview.appspot.com/7381060/diff/6001/app/templates/overview.handl...
app/templates/overview.handlebars:9: <li class="landscape-reboot"><a
href="#">Machine Restart Needed</a></li>
On 2013/02/27 16:31:41, gary.poster wrote:
> I vote for consistency.  If we have the <a href="#"> for these two, let's have
> them for the previous three as well, unless there's a reason not to.

The others are event bound items that if anything transition within the
application. These are external links designed to escape the application.

https://codereview.appspot.com/7381060/diff/6001/app/views/topology/service.js
File app/views/topology/service.js (right):

https://codereview.appspot.com/7381060/diff/6001/app/views/topology/service.j...
app/views/topology/service.js:909: landscapeSecurity.show().one('a').set('href',
securityURL);
On 2013/02/27 16:31:41, gary.poster wrote:
> Why don't we need to hide these otherwise?  I'll QA it in a sec, so if it
works,
> nm, though I would like to understand.

They are hidden in the 'var' section during selection. Previously the menu was
just moved to a new item and the only context that changed was the 'box' but now
we 

hide, 
see if we need to show links
  show and update links in the context of box

[bcsaller, 2013-02-27 16:42:51]

*** Submitted:

Landscape service menu integration

Service menu items appear if landscape tells us 
we need them.

R=jeff.pihach, goodspud, gary.poster
CC=
https://codereview.appspot.com/7381060