Issue 7381048: code review 7381048: runtime: minor changes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 7381048: code review 7381048: runtime: minor changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 3 months ago by dvyukov

Modified:
12 years, 3 months ago

Reviewers:

CC:
golang-dev, rsc

Visibility:
Public.

Description

runtime: minor changes to minimize diffs of new scheduler

Patch Set 2 : diff -r 3391481b6373 https://dvyukov%40google.com@code.google.com/p/go/ #

Total comments: 2

Patch Set 3 : diff -r 3391481b6373 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 3391481b6373 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r 3391481b6373 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r 3391481b6373 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 7 : diff -r 237f213fc927 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 8 : diff -r e00da5e201e5 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -23 lines)			Patch
	M	src/pkg/runtime/proc.c	View	1 2 3 4 5 6	14 chunks	+49 lines, -23 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

https://codereview.appspot.com/7381048/diff/2001/src/pkg/runtime/proc.c File src/pkg/runtime/proc.c (right): https://codereview.appspot.com/7381048/diff/2001/src/pkg/runtime/proc.c#newcode681 src/pkg/runtime/proc.c:681: runtime·unlock(&runtime·sched); exitsyscall() can modify mwait concurrently https://codereview.appspot.com/7381048/diff/2001/src/pkg/runtime/proc.c#newcode1653 src/pkg/runtime/proc.c:1653: runtime·lock(&runtime·sched); ...

12 years, 3 months ago (2013-02-21 10:19:45 UTC) #1

dvyukov

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 3 months ago (2013-02-21 10:40:45 UTC) #2

dvyukov

12 years, 3 months ago (2013-02-23 04:42:20 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=3fd30cfcc147 ***

runtime: minor changes
to minimize diffs of new scheduler

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/7381048

Expand All Messages | Collapse All Messages